bpf: test_run: fix atomic context in timer path causing sleep-in-atomic BUG #6126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 39e9d5f |
Author
|
Upstream branch: 39e9d5f |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1010864=>bpf-next
branch
from
5874fae to
c3de733
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
06bf66d to
4b3a35b
Compare
Author
|
Upstream branch: 39e9d5f |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1010864=>bpf-next
branch
from
c3de733 to
efca8ad
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4b3a35b to
ec7437a
Compare
Author
|
Upstream branch: 48a97ff |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1010864=>bpf-next
branch
from
efca8ad to
61f42f7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
ec7437a to
fa9b89f
Compare
Author
|
Upstream branch: 27aab47 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1010864=>bpf-next
branch
from
61f42f7 to
94f63d8
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
fa9b89f to
631bcf6
Compare
Author
|
Upstream branch: 48a97ff |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1010864=>bpf-next
branch
from
94f63d8 to
857ff6a
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
631bcf6 to
db45b16
Compare
Author
|
Upstream branch: 48a97ff |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1010864=>bpf-next
branch
from
857ff6a to
c31fecf
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
db45b16 to
cf0c057
Compare
Author
|
Upstream branch: 48a97ff |
…ic BUG The timer mode is initialized to NO_PREEMPT mode by default, this disable preemption and force execution in atomic context causing issue on PREEMPT_RT configurations when invoking spin_lock_bh(), leading to the following warning: BUG: sleeping function called from invalid context at kernel/locking/spinlock_rt.c:48 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 6107, name: syz.0.17 preempt_count: 1, expected: 0 RCU nest depth: 1, expected: 1 Preemption disabled at: [<ffffffff891fce58>] bpf_test_timer_enter+0xf8/0x140 net/bpf/test_run.c:42 Fix this, by removing NO_PREEMPT/NO_MIGRATE mode check. Also, the test timer context no longer needs explicit calls to migrate_disable()/migrate_enable() with rcu_read_lock()/rcu_read_unlock(). Use helpers rcu_read_lock_dont_migrate() and rcu_read_unlock_migrate() instead. Reported-by: [email protected] Closes: https://syzkaller.appspot.com/bug?extid=1f1fbecb9413cdbfbef8 Tested-by: [email protected] Signed-off-by: Sahil Chandna <[email protected]> Acked-by: Yonghong Song <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1010864=>bpf-next
branch
from
c31fecf to
b188205
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1010864 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: test_run: fix atomic context in timer path causing sleep-in-atomic BUG
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1010864