bpf: add and use migrate_enable_rcu #6134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out migrate_enable_rcu/migrate_disable_rcu from rcu_read_lock_dont_migrate/rcu_read_unlock_migrate. These functions will be used in the following patches. It's a little weird to define them in rcupdate.h. Maybe we should move them to sched.h? Signed-off-by: Menglong Dong <[email protected]>
Introduce bpf_prog_run_pin_on_cpu_rcu(), which will be called with rcu_read_lock. migrate_disable_rcu and migrate_enable_rcu are used to get better performance when CONFIG_PREEMPT_RCU is not enabled. Signed-off-by: Menglong Dong <[email protected]>
Replace bpf_prog_run_pin_on_cpu() with bpf_prog_run_pin_on_cpu_rcu() in following functions to obtain better performance: sk_psock_msg_verdict sk_psock_tls_strp_read sk_psock_strp_read sk_psock_strp_parse sk_psock_verdict_recv Signed-off-by: Menglong Dong <[email protected]>
All the calling of bpf_prog_run_clear_cb() is protected with rcu_read_lock, so we can replace bpf_prog_run_pin_on_cpu() with bpf_prog_run_pin_on_cpu_rcu() for it. Signed-off-by: Menglong Dong <[email protected]>
Author
|
Upstream branch: 39e9d5f |
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1011237 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: add and use migrate_enable_rcu
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1011237