selftests/bpf: make arg_parsing.c more robust to crashes #6138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 39e9d5f |
Author
|
Upstream branch: 39e9d5f |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1011516=>bpf-next
branch
from
e164195 to
c30fec6
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
06bf66d to
4b3a35b
Compare
Author
|
Upstream branch: 39e9d5f |
We started getting a crash in BPF CI, which seems to originate from
test_parse_test_list_file() test and is happening at this line:
ASSERT_OK(strcmp("test_with_spaces", set.tests[0].name), "test 0 name");
One way we can crash there is if set.cnt zero, which is checked for with
ASSERT_EQ() above, but we proceed after this regardless of the outcome.
Instead of crashing, we should bail out with test failure early.
Similarly, if parse_test_list_file() fails, we shouldn't be even looking
at set, so bail even earlier if ASSERT_OK() fails.
Fixes: 64276f0 ("selftests/bpf: Test_progs can read test lists from file")
Signed-off-by: Andrii Nakryiko <[email protected]>
Tested-by: Ihor Solodrai <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1011516=>bpf-next
branch
from
c30fec6 to
12a27d2
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1011516 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: make arg_parsing.c more robust to crashes
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1011516