selftests/bpf: convert test_tc_tunnel.sh to test_progs

[kernel-patches-daemon-bpf-rc]

Pull request for series with
subject: selftests/bpf: convert test_tc_tunnel.sh to test_progs
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1012903

[kernel-patches-daemon-bpf-rc]

Upstream branch: 48a97ff
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1012903
version: 1

[kernel-patches-review-bot]

commit 4ae5a37cdd34256a1ebc8a04f8fae87778c5d921
Author: Alexis Lothoré (eBPF Foundation) <[email protected]>

selftests/bpf: integrate test_tc_tunnel.sh tests into test_progs

This commit integrates the test_tc_tunnel.sh script into the test_progs
framework by creating a new test file that validates various tunneling
mechanisms. The test checks that BPF programs can handle encapsulation and
decapsulation for multiple tunnel types.

> diff --git a/tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c b/tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c
> new file mode 100644
> index 000000000..294cf4fb1
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/test_tc_tunnel.c

[ ... ]

> +static int run_server(struct subtest_cfg *cfg)
> +{
> +	struct nstoken *nstoken = open_netns(SERVER_NS);
> +	int family = cfg->ipproto == 6 ? AF_INET6 : AF_INET;
> +
> +	cfg->server_fd = start_reuseport_server(family, SOCK_STREAM,
> +						cfg->server_addr, TEST_PORT,
> +						TIMEOUT_MS, 1);
> +	close_netns(nstoken);
> +	if (!ASSERT_NEQ(cfg->server_fd, NULL, "start server"))
> +		return -1;
> +
> +	return 0;
> +}
> +
> +static void stop_server(struct subtest_cfg *cfg)
> +{
> +	struct nstoken *nstoken = open_netns(SERVER_NS);
> +
> +	close(*cfg->server_fd);
> +	cfg->server_fd = NULL;
> +	close_netns(nstoken);
> +}

Can stop_server() dereference a NULL pointer if run_server() failed?
Looking at run_test(), if run_server() returns -1, the code jumps to
the fail label which unconditionally calls stop_server(). But when
run_server() fails, cfg->server_fd is never set and remains at
whatever value it had (likely uninitialized or from a previous test).

Also, does this code leak the server_fd array? The start_reuseport_server()
function allocates an array of file descriptors using malloc() and returns
the pointer. The matching cleanup function is free_fds() which both closes
all the file descriptors and frees the allocated array. Here in
stop_server(), only close() is called on the first file descriptor, but
the array itself is never freed with free_fds().

> +static void run_test(struct subtest_cfg *cfg)
> +{
> +	if (!ASSERT_OK(run_server(cfg), "run server"))
> +		goto fail;
> +
> +	// Basic communication must work
> +	if (!ASSERT_OK(send_and_test_data(cfg, true), "connect without any encap"))
> +		goto fail;
> +
> +	// Attach encapsulation program to client, communication must fail
> +	if (!ASSERT_OK(configure_encapsulation(cfg), "configure encapsulation"))
> +		return;
> +	if (!ASSERT_OK(send_and_test_data(cfg, false), "connect with encap prog only"))
> +		goto fail;
> +
> +	/* Insert kernel decap module, connection must succeed */
> +	if (!ASSERT_OK(configure_kernel_decapsulation(cfg), "configure kernel decapsulation"))
> +		goto fail;
> +	if (!ASSERT_OK(send_and_test_data(cfg, !cfg->expect_kern_decap_failure),
> +		       "connect with encap prog and kern decap"))
> +		goto fail;
> +
> +	// Replace kernel module with BPF decap, test must pass
> +	if (!ASSERT_OK(configure_ebpf_decapsulation(cfg), "configure ebpf decapsulation"))
> +		goto fail;
> +	ASSERT_OK(send_and_test_data(cfg, true), "connect with encap and decap progs");
> +
> +fail:
> +	stop_server(cfg);
> +}

[ ... ]

---

AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md

In-Reply-To-Subject: selftests/bpf: integrate test_tc_tunnel.sh tests into test_progs
CI run summary: https://github.com/kernel-patches/bpf-rc/actions/runs/18596012432

[kernel-patches-daemon-bpf-rc]

Forwarding comment 3415900283 via email
In-Reply-To: [email protected]
Patch: https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

[kernel-patches-daemon-bpf-rc]

Upstream branch: 48a97ff
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=1012903
version: 1

[kernel-patches-daemon-bpf-rc]

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1012903 expired. Closing PR.