bpf: liveness: Handle ERR_PTR from get_outer_instance() in propagate_to_outer_instance() #6179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 1c64efc |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf_base
branch
from
d564564 to
fd2f251
Compare
Author
|
Upstream branch: 1c64efc |
…to_outer_instance() propagate_to_outer_instance() calls get_outer_instance() and then uses the returned pointer to reset/commit stack write marks. When get_outer_instance() fails (e.g., __lookup_instance() returns -ENOMEM), it may return an ERR_PTR. Without a check, the code dereferences this error pointer. Protect the call with IS_ERR() and propagate the error. Reported-by: kernel-patches-review-bot (kernel-patches/bpf#10006 (comment)) Signed-off-by: Shardul Bankar <[email protected]> v2: Drop Fixes tag per Eduard’s review (not a functional bug).
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013390=>bpf
branch
from
ed7768d to
bd93585
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1013390 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: liveness: Handle ERR_PTR from get_outer_instance() in propagate_to_outer_instance()
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1013390