selftests/bpf: Change variable types for -Wsign-compare #6182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 7361c86 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
b7224b3 to
2b803ce
Compare
Author
|
Upstream branch: 04a8995 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
6e8713c to
a6d4574
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2b803ce to
9b33bf7
Compare
Author
|
Upstream branch: 04a8995 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
a6d4574 to
cd70041
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
9b33bf7 to
33b4c7f
Compare
Author
|
Upstream branch: 96d31df |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
cd70041 to
a1e7ab7
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
33b4c7f to
e698de7
Compare
Author
|
Upstream branch: e758657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
a1e7ab7 to
93732f0
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
e698de7 to
ee5122f
Compare
Author
|
Upstream branch: e758657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
93732f0 to
ede9c3f
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
ee5122f to
d5592b9
Compare
Author
|
Upstream branch: e758657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
ede9c3f to
6c6c686
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
d5592b9 to
27d6d8b
Compare
Author
|
Upstream branch: e758657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
6c6c686 to
9e48726
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
27d6d8b to
4d1f3ab
Compare
Author
|
Upstream branch: e758657 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
9e48726 to
6b58830
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
4d1f3ab to
7ba9a34
Compare
Author
|
Upstream branch: ff88079 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
6b58830 to
afdf607
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
7ba9a34 to
2991dd5
Compare
Author
|
Upstream branch: f9db3a3 |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
afdf607 to
5abd5fd
Compare
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
bpf-next_base
branch
from
2991dd5 to
583dec7
Compare
Author
|
Upstream branch: 8842732 |
This is a follow up patch for commit 495d2d8("selftests/bpf: Attempt to build BPF programs with -Wsign-compare") from Alexei Starovoitov[1] to be able to enable -Wsign-compare C compilation flag for clang since -Wall doesn't add it and BPF programs are built with clang.This has the benefit to catch problematic comparisons in future tests as quoted from the commit message:" int i = -1; unsigned int j = 1; if (i < j) // this is false. long i = -1; unsigned int j = 1; if (i < j) // this is true. C standard for reference: - If either operand is unsigned long the other shall be converted to unsigned long. - Otherwise, if one operand is a long int and the other unsigned int, then if a long int can represent all the values of an unsigned int, the unsigned int shall be converted to a long int; otherwise both operands shall be converted to unsigned long int. - Otherwise, if either operand is long, the other shall be converted to long. - Otherwise, if either operand is unsigned, the other shall be converted to unsigned. Unfortunately clang's -Wsign-compare is very noisy. It complains about (s32)a == (u32)b which is safe and doen't have surprising behavior." This specific patch supresses the following warnings when -Wsign-compare is enabled: 1 warning generated. progs/bpf_iter_bpf_percpu_array_map.c:35:16: warning: comparison of integers of different signs: 'int' and 'const volatile __u32' (aka 'const volatile unsigned int') [-Wsign-compare] 35 | for (i = 0; i < num_cpus; i++) { | ~ ^ ~~~~~~~~ 1 warning generated. progs/bpf_qdisc_fifo.c:93:2: warning: comparison of integers of different signs: 'int' and '__u32' (aka 'unsigned int') [-Wsign-compare] 93 | bpf_for(i, 0, sch->q.qlen) { | ^ ~ ~~~~~~~~~~~ Should be noted that many more similar changes are still needed in order to be able to enable the -Wsign-compare flag since -Werror is enabled and would cause compilation of bpf selftests to fail. [1]. Link:torvalds/linux@495d2d8 Signed-off-by: Mehdi Ben Hadj Khelifa <[email protected]>
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013549=>bpf-next
branch
from
5abd5fd to
d8b76d3
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1013549 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: Change variable types for -Wsign-compare
version: 4
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1013549