bpf: liveness: clarify get_outer_instance() handling in propagate_to_outer_instance() #6191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: 1c64efc |
…outer_instance() propagate_to_outer_instance() calls get_outer_instance() and uses the returned pointer to reset and commit stack write marks. Under normal conditions, update_instance() guarantees that an outer instance exists, so get_outer_instance() cannot return an ERR_PTR. However, explicitly checking for IS_ERR(outer_instance) makes this code more robust and self-documenting. It reduces cognitive load when reading the control flow and silences potential false-positive reports from static analysis or automated tooling. No functional change intended. Reported-by: kernel-patches-review-bot (kernel-patches/bpf#10006 (comment)) Suggested-by: Eduard Zingerman <[email protected]> Signed-off-by: Shardul Bankar <[email protected]> Acked-by: Eduard Zingerman <[email protected]>
Author
|
Upstream branch: 1c64efc |
kernel-patches-daemon-bpf-rc
bot
force-pushed
the
series/1013903=>bpf
branch
from
e93c759 to
353c481
Compare
Author
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=1013903 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: bpf: liveness: clarify get_outer_instance() handling in propagate_to_outer_instance()
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1013903