Skip to content

Commit 05a0ffe

Browse files
ukleinekgroeck
authored andcommitted
dt-bindings: hwmon: adt7475: Allow and recommend #pwm-cells = <3>
To make this binding match what is usally used for PWMs, deprecate 4 cells and allow 3 instead. Signed-off-by: Uwe Kleine-König <[email protected]> Reviewed-by: Rob Herring (Arm) <[email protected]> Link: https://lore.kernel.org/r/77895aec937b6217f513d3b12e7945f1707fd906.1750361514.git.u.kleine-koenig@baylibre.com Signed-off-by: Guenter Roeck <[email protected]>
1 parent 50f1607 commit 05a0ffe

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Documentation/devicetree/bindings/hwmon/adt7475.yaml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,10 @@ properties:
5353
default: 1
5454

5555
"#pwm-cells":
56-
const: 4
56+
oneOf:
57+
- const: 3
58+
- const: 4
59+
deprecated: true
5760
description: |
5861
Number of cells in a PWM specifier.
5962
- 0: The PWM channel
@@ -68,7 +71,7 @@ properties:
6871
- 11363636 (88 Hz)
6972
- 44444 (22 kHz)
7073
- 2: PWM flags 0 or PWM_POLARITY_INVERTED
71-
- 3: The default PWM duty cycle in nanoseconds
74+
- 3: The default PWM duty cycle in nanoseconds, defaults to period.
7275
7376
patternProperties:
7477
"^adi,bypass-attenuator-in[0-4]$":
@@ -124,15 +127,15 @@ examples:
124127
adi,bypass-attenuator-in1 = <0>;
125128
adi,pin10-function = "smbalert#";
126129
adi,pin14-function = "tach4";
127-
#pwm-cells = <4>;
130+
#pwm-cells = <3>;
128131
129-
/* PWMs at 22.5 kHz frequency, 50% duty*/
132+
/* PWMs at 22.5 kHz frequency */
130133
fan-0 {
131-
pwms = <&pwm 0 44444 0 22222>;
134+
pwms = <&pwm 0 44444 0>;
132135
};
133136
134137
fan-1 {
135-
pwms = <&pwm 2 44444 0 22222>;
138+
pwms = <&pwm 2 44444 0>;
136139
};
137140
};
138141
};

0 commit comments

Comments
 (0)