Skip to content

Commit 0c82f50

Browse files
committed
kconfig: gconf: fix behavior of a menu under a symbol in split view
A menu can be created under a symbol. [Example] menu "outer menu" config A bool "A" menu "inner menu" depends on A config B bool "B" endmenu endmenu After being re-parented by menu_finalize(), the menu tree is structured like follows: menu "outer menu" \-- A \-- menu "inner menu" \-- B In split view, the symbol A is shown in the right pane, so all of its descendants must also be shown there. This has never worked correctly. Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 1f937cd commit 0c82f50

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

scripts/kconfig/gconf.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -803,7 +803,7 @@ static gboolean on_treeview2_button_press_event(GtkWidget *widget,
803803
enum prop_type ptype;
804804
ptype = menu->prompt ? menu->prompt->type : P_UNKNOWN;
805805

806-
if (ptype == P_MENU && view_mode != FULL_VIEW && col == COL_OPTION) {
806+
if (ptype == P_MENU && view_mode == SINGLE_VIEW && col == COL_OPTION) {
807807
// goes down into menu
808808
browsed = menu;
809809
display_tree_part();
@@ -953,8 +953,7 @@ static void _display_tree(GtkTreeStore *tree, struct menu *menu,
953953
gtk_tree_store_append(tree, &iter, parent);
954954
set_node(tree, &iter, child);
955955

956-
if ((view_mode != FULL_VIEW) && (ptype == P_MENU)
957-
&& (tree == tree2))
956+
if ((view_mode == SINGLE_VIEW) && (ptype == P_MENU))
958957
continue;
959958
/*
960959
if (((menu != &rootmenu) && !(menu->flags & MENU_ROOT))

0 commit comments

Comments
 (0)