Skip to content

Commit 0cb39c9

Browse files
hcahcaAlexander Gordeev
authored andcommitted
s390/smp: Remove conditional emergency signal order code usage
pcpu_ec_call() uses either the external call or emergency signal order code to signal (aka send an IPI) to a remote CPU. If the remote CPU is not running the emergency signal order is used. Measurements show that always using the external order code is at least as good, and sometimes even better, than the existing code. Therefore remove emergency signal order code usage from pcpu_ec_call(). Suggested-by: Christian Borntraeger <[email protected]> Acked-by: Christian Borntraeger <[email protected]> Reviewed-by: Alexander Gordeev <[email protected]> Signed-off-by: Heiko Carstens <[email protected]> Signed-off-by: Alexander Gordeev <[email protected]>
1 parent a3d0b7a commit 0cb39c9

File tree

1 file changed

+1
-4
lines changed

1 file changed

+1
-4
lines changed

arch/s390/kernel/smp.c

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,13 +175,10 @@ static struct pcpu *pcpu_find_address(const struct cpumask *mask, u16 address)
175175

176176
static void pcpu_ec_call(struct pcpu *pcpu, int ec_bit)
177177
{
178-
int order;
179-
180178
if (test_and_set_bit(ec_bit, &pcpu->ec_mask))
181179
return;
182-
order = pcpu_running(pcpu) ? SIGP_EXTERNAL_CALL : SIGP_EMERGENCY_SIGNAL;
183180
pcpu->ec_clk = get_tod_clock_fast();
184-
pcpu_sigp_retry(pcpu, order, 0);
181+
pcpu_sigp_retry(pcpu, SIGP_EXTERNAL_CALL, 0);
185182
}
186183

187184
static int pcpu_alloc_lowcore(struct pcpu *pcpu, int cpu)

0 commit comments

Comments
 (0)