Skip to content

Commit 15a5ae3

Browse files
committed
kconfig: gconf: Fix Back button behavior
Clicking the Back button may navigate to a non-menu hierarchy level. [Example] menu "menu1" config A bool "A" default y config B bool "B" depends on A default y menu "menu2" depends on B config C bool "C" default y endmenu endmenu After being re-parented by menu_finalize(), the menu tree is structured like follows: menu "menu1" \-- A \-- B \-- menu "menu2" \-- C In Single view, visit "menu2" and click the Back button. It should go up to "menu1" and show A, B and "menu2", but instead goes up to A and show only B and "menu2". This is a bug in on_back_clicked(). Signed-off-by: Masahiro Yamada <[email protected]>
1 parent 6d4d442 commit 15a5ae3

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

scripts/kconfig/gconf.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -553,12 +553,8 @@ static void on_license1_activate(GtkMenuItem *menuitem, gpointer user_data)
553553
/* toolbar handlers */
554554
static void on_back_clicked(GtkButton *button, gpointer user_data)
555555
{
556-
enum prop_type ptype;
556+
browsed = menu_get_parent_menu(browsed) ?: &rootmenu;
557557

558-
browsed = browsed->parent;
559-
ptype = browsed->prompt ? browsed->prompt->type : P_UNKNOWN;
560-
if (ptype != P_MENU)
561-
browsed = browsed->parent;
562558
recreate_tree();
563559

564560
if (browsed == &rootmenu)

0 commit comments

Comments
 (0)