Skip to content

Commit 15eece6

Browse files
cuiyunhuirafaeljw
authored andcommitted
ACPI: CPPC: Fix NULL pointer dereference when nosmp is used
With nosmp in cmdline, other CPUs are not brought up, leaving their cpc_desc_ptr NULL. CPU0's iteration via for_each_possible_cpu() dereferences these NULL pointers, causing panic. Panic backtrace: [ 0.401123] Unable to handle kernel NULL pointer dereference at virtual address 00000000000000b8 ... [ 0.403255] [<ffffffff809a5818>] cppc_allow_fast_switch+0x6a/0xd4 ... Kernel panic - not syncing: Attempted to kill init! Fixes: 3cc30dd ("cpufreq: CPPC: Enable fast_switch") Reported-by: Xu Lu <[email protected]> Signed-off-by: Yunhui Cui <[email protected]> Link: https://patch.msgid.link/[email protected] [ rjw: New subject ] Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent 19272b3 commit 15eece6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/acpi/cppc_acpi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -476,7 +476,7 @@ bool cppc_allow_fast_switch(void)
476476
struct cpc_desc *cpc_ptr;
477477
int cpu;
478478

479-
for_each_possible_cpu(cpu) {
479+
for_each_present_cpu(cpu) {
480480
cpc_ptr = per_cpu(cpc_desc_ptr, cpu);
481481
desired_reg = &cpc_ptr->cpc_regs[DESIRED_PERF];
482482
if (!CPC_IN_SYSTEM_MEMORY(desired_reg) &&

0 commit comments

Comments
 (0)