Skip to content

Commit 1649753

Browse files
eddyz87anakryiko
authored andcommitted
veristat: Strerror expects positive number (errno)
Before: ./veristat -G @foobar iters.bpf.o Failed to open presets in 'foobar': Unknown error -2 ... After: ./veristat -G @foobar iters.bpf.o Failed to open presets in 'foobar': No such file or directory ... Signed-off-by: Eduard Zingerman <[email protected]> Signed-off-by: Andrii Nakryiko <[email protected]> Acked-by: Mykyta Yatsenko <[email protected]> Link: https://lore.kernel.org/bpf/[email protected]
1 parent 128cd76 commit 1649753

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/bpf/veristat.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -660,7 +660,7 @@ static int append_filter_file(const char *path)
660660
f = fopen(path, "r");
661661
if (!f) {
662662
err = -errno;
663-
fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(err));
663+
fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(-err));
664664
return err;
665665
}
666666

@@ -1422,7 +1422,7 @@ static int append_var_preset_file(const char *filename)
14221422
f = fopen(filename, "rt");
14231423
if (!f) {
14241424
err = -errno;
1425-
fprintf(stderr, "Failed to open presets in '%s': %s\n", filename, strerror(err));
1425+
fprintf(stderr, "Failed to open presets in '%s': %s\n", filename, strerror(-err));
14261426
return -EINVAL;
14271427
}
14281428

0 commit comments

Comments
 (0)