Skip to content

Commit 1d738db

Browse files
sean-jcbp3tk0v
authored andcommitted
drm/gpu: Remove dead checks on wbinvd_on_all_cpus()'s return value
Remove the checks and associated pr_err() on wbinvd_on_all_cpus() failure, as the helper has unconditionally returned 0/success since commit caa7593 ("smp: Remove smp_call_function() and on_each_cpu() return values"). Signed-off-by: Sean Christopherson <[email protected]> Signed-off-by: Borislav Petkov (AMD) <[email protected]> Link: https://lore.kernel.org/[email protected]
1 parent d7b8f8e commit 1d738db

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

drivers/gpu/drm/drm_cache.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,8 +93,7 @@ drm_clflush_pages(struct page *pages[], unsigned long num_pages)
9393
return;
9494
}
9595

96-
if (wbinvd_on_all_cpus())
97-
pr_err("Timed out waiting for cache flush\n");
96+
wbinvd_on_all_cpus();
9897

9998
#elif defined(__powerpc__)
10099
unsigned long i;
@@ -139,8 +138,7 @@ drm_clflush_sg(struct sg_table *st)
139138
return;
140139
}
141140

142-
if (wbinvd_on_all_cpus())
143-
pr_err("Timed out waiting for cache flush\n");
141+
wbinvd_on_all_cpus();
144142
#else
145143
WARN_ONCE(1, "Architecture has no drm_cache.c support\n");
146144
#endif
@@ -172,8 +170,7 @@ drm_clflush_virt_range(void *addr, unsigned long length)
172170
return;
173171
}
174172

175-
if (wbinvd_on_all_cpus())
176-
pr_err("Timed out waiting for cache flush\n");
173+
wbinvd_on_all_cpus();
177174
#else
178175
WARN_ONCE(1, "Architecture has no drm_cache.c support\n");
179176
#endif

0 commit comments

Comments
 (0)