Skip to content

Commit 22b246e

Browse files
ahunter6martinkpetersen
authored andcommitted
scsi: ufs: ufs-pci: Remove control of UIC Completion interrupt for Intel MTL
Now that UFS core enables the UIC Completion interrupt only when needed, Intel MTL driver no longer needs to control the interrupt itself. So remove the associated code. Signed-off-by: Adrian Hunter <[email protected]> Link: https://lore.kernel.org/r/[email protected] Reviewed-by: Bart Van Assche <[email protected]> Signed-off-by: Martin K. Petersen <[email protected]>
1 parent d402b20 commit 22b246e

File tree

1 file changed

+0
-27
lines changed

1 file changed

+0
-27
lines changed

drivers/ufs/host/ufshcd-pci.c

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -211,32 +211,6 @@ static int ufs_intel_lkf_apply_dev_quirks(struct ufs_hba *hba)
211211
return ret;
212212
}
213213

214-
static void ufs_intel_ctrl_uic_compl(struct ufs_hba *hba, bool enable)
215-
{
216-
u32 set = ufshcd_readl(hba, REG_INTERRUPT_ENABLE);
217-
218-
if (enable)
219-
set |= UIC_COMMAND_COMPL;
220-
else
221-
set &= ~UIC_COMMAND_COMPL;
222-
ufshcd_writel(hba, set, REG_INTERRUPT_ENABLE);
223-
}
224-
225-
static void ufs_intel_mtl_h8_notify(struct ufs_hba *hba,
226-
enum uic_cmd_dme cmd,
227-
enum ufs_notify_change_status status)
228-
{
229-
/*
230-
* Disable UIC COMPL INTR to prevent access to UFSHCI after
231-
* checking HCS.UPMCRS
232-
*/
233-
if (status == PRE_CHANGE && cmd == UIC_CMD_DME_HIBER_ENTER)
234-
ufs_intel_ctrl_uic_compl(hba, false);
235-
236-
if (status == POST_CHANGE && cmd == UIC_CMD_DME_HIBER_EXIT)
237-
ufs_intel_ctrl_uic_compl(hba, true);
238-
}
239-
240214
#define INTEL_ACTIVELTR 0x804
241215
#define INTEL_IDLELTR 0x808
242216

@@ -549,7 +523,6 @@ static struct ufs_hba_variant_ops ufs_intel_mtl_hba_vops = {
549523
.init = ufs_intel_mtl_init,
550524
.exit = ufs_intel_common_exit,
551525
.hce_enable_notify = ufs_intel_hce_enable_notify,
552-
.hibern8_notify = ufs_intel_mtl_h8_notify,
553526
.link_startup_notify = ufs_intel_link_startup_notify,
554527
.resume = ufs_intel_resume,
555528
.device_reset = ufs_intel_device_reset,

0 commit comments

Comments
 (0)