Skip to content

Commit 23972da

Browse files
Bartosz Golaszewskiandersson
authored andcommitted
firmware: qcom: scm: remove unused arguments from SHM bridge routines
qcom_scm_shm_bridge_create() and qcom_scm_shm_bridge_delete() take struct device as argument but don't use it. Remove it from these functions' prototypes. Reviewed-by: Konrad Dybcio <[email protected]> Signed-off-by: Bartosz Golaszewski <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 84684c5 commit 23972da

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

drivers/firmware/qcom/qcom_scm.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1631,7 +1631,7 @@ int qcom_scm_shm_bridge_enable(void)
16311631
}
16321632
EXPORT_SYMBOL_GPL(qcom_scm_shm_bridge_enable);
16331633

1634-
int qcom_scm_shm_bridge_create(struct device *dev, u64 pfn_and_ns_perm_flags,
1634+
int qcom_scm_shm_bridge_create(u64 pfn_and_ns_perm_flags,
16351635
u64 ipfn_and_s_perm_flags, u64 size_and_flags,
16361636
u64 ns_vmids, u64 *handle)
16371637
{
@@ -1659,7 +1659,7 @@ int qcom_scm_shm_bridge_create(struct device *dev, u64 pfn_and_ns_perm_flags,
16591659
}
16601660
EXPORT_SYMBOL_GPL(qcom_scm_shm_bridge_create);
16611661

1662-
int qcom_scm_shm_bridge_delete(struct device *dev, u64 handle)
1662+
int qcom_scm_shm_bridge_delete(u64 handle)
16631663
{
16641664
struct qcom_scm_desc desc = {
16651665
.svc = QCOM_SCM_SVC_MP,

drivers/firmware/qcom/qcom_tzmem.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,9 @@ static int qcom_tzmem_init_area(struct qcom_tzmem_area *area)
124124
if (!handle)
125125
return -ENOMEM;
126126

127-
ret = qcom_scm_shm_bridge_create(qcom_tzmem_dev, pfn_and_ns_perm,
128-
ipfn_and_s_perm, size_and_flags,
129-
QCOM_SCM_VMID_HLOS, handle);
127+
ret = qcom_scm_shm_bridge_create(pfn_and_ns_perm, ipfn_and_s_perm,
128+
size_and_flags, QCOM_SCM_VMID_HLOS,
129+
handle);
130130
if (ret)
131131
return ret;
132132

@@ -142,7 +142,7 @@ static void qcom_tzmem_cleanup_area(struct qcom_tzmem_area *area)
142142
if (!qcom_tzmem_using_shm_bridge)
143143
return;
144144

145-
qcom_scm_shm_bridge_delete(qcom_tzmem_dev, *handle);
145+
qcom_scm_shm_bridge_delete(*handle);
146146
kfree(handle);
147147
}
148148

include/linux/firmware/qcom/qcom_scm.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,10 +149,10 @@ bool qcom_scm_lmh_dcvsh_available(void);
149149
int qcom_scm_gpu_init_regs(u32 gpu_req);
150150

151151
int qcom_scm_shm_bridge_enable(void);
152-
int qcom_scm_shm_bridge_create(struct device *dev, u64 pfn_and_ns_perm_flags,
152+
int qcom_scm_shm_bridge_create(u64 pfn_and_ns_perm_flags,
153153
u64 ipfn_and_s_perm_flags, u64 size_and_flags,
154154
u64 ns_vmids, u64 *handle);
155-
int qcom_scm_shm_bridge_delete(struct device *dev, u64 handle);
155+
int qcom_scm_shm_bridge_delete(u64 handle);
156156

157157
#ifdef CONFIG_QCOM_QSEECOM
158158

0 commit comments

Comments
 (0)