Skip to content

Commit 3b0abc4

Browse files
rohitvisavaliabebarino
authored andcommitted
clk: xilinx: vcu: unregister pll_post only if registered correctly
If registration of pll_post is failed, it will be set to NULL or ERR, unregistering same will fail with following call trace: Unable to handle kernel NULL pointer dereference at virtual address 008 pc : clk_hw_unregister+0xc/0x20 lr : clk_hw_unregister_fixed_factor+0x18/0x30 sp : ffff800011923850 ... Call trace: clk_hw_unregister+0xc/0x20 clk_hw_unregister_fixed_factor+0x18/0x30 xvcu_unregister_clock_provider+0xcc/0xf4 [xlnx_vcu] xvcu_probe+0x2bc/0x53c [xlnx_vcu] Fixes: 4472e18 ("soc: xilinx: vcu: make pll post divider explicit") Signed-off-by: Rohit Visavalia <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Stephen Boyd <[email protected]>
1 parent 19272b3 commit 3b0abc4

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/clk/xilinx/xlnx_vcu.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -587,8 +587,8 @@ static void xvcu_unregister_clock_provider(struct xvcu_device *xvcu)
587587
xvcu_clk_hw_unregister_leaf(hws[CLK_XVCU_ENC_MCU]);
588588
if (!IS_ERR_OR_NULL(hws[CLK_XVCU_ENC_CORE]))
589589
xvcu_clk_hw_unregister_leaf(hws[CLK_XVCU_ENC_CORE]);
590-
591-
clk_hw_unregister_fixed_factor(xvcu->pll_post);
590+
if (!IS_ERR_OR_NULL(xvcu->pll_post))
591+
clk_hw_unregister_fixed_factor(xvcu->pll_post);
592592
}
593593

594594
/**

0 commit comments

Comments
 (0)