Skip to content

Commit 4a3556b

Browse files
Kathiravan Thirumoorthyvinodkoul
authored andcommitted
phy: qcom: phy-qcom-m31: Update IPQ5332 M31 USB phy initialization sequence
The current configuration used for the IPQ5332 M31 USB PHY fails the Near End High Speed Signal Quality compliance test. To resolve this, update the initialization sequence as specified in the Hardware Design Document. Fixes: 08e49af ("phy: qcom: Introduce M31 USB PHY driver") Cc: [email protected] Signed-off-by: Kathiravan Thirumoorthy <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Link: https://lore.kernel.org/r/20250630-ipq5332_hsphy_complaince-v2-1-63621439ebdb@oss.qualcomm.com Signed-off-by: Vinod Koul <[email protected]>
1 parent 4c3d05d commit 4a3556b

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

drivers/phy/qualcomm/phy-qcom-m31.c

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,14 +58,16 @@
5858
#define USB2_0_TX_ENABLE BIT(2)
5959

6060
#define USB2PHY_USB_PHY_M31_XCFGI_4 0xc8
61-
#define HSTX_SLEW_RATE_565PS GENMASK(1, 0)
61+
#define HSTX_SLEW_RATE_400PS GENMASK(2, 0)
6262
#define PLL_CHARGING_PUMP_CURRENT_35UA GENMASK(4, 3)
6363
#define ODT_VALUE_38_02_OHM GENMASK(7, 6)
6464

6565
#define USB2PHY_USB_PHY_M31_XCFGI_5 0xcc
66-
#define ODT_VALUE_45_02_OHM BIT(2)
6766
#define HSTX_PRE_EMPHASIS_LEVEL_0_55MA BIT(0)
6867

68+
#define USB2PHY_USB_PHY_M31_XCFGI_9 0xdc
69+
#define HSTX_CURRENT_17_1MA_385MV BIT(1)
70+
6971
#define USB2PHY_USB_PHY_M31_XCFGI_11 0xe4
7072
#define XCFG_COARSE_TUNE_NUM BIT(1)
7173
#define XCFG_FINE_TUNE_NUM BIT(3)
@@ -164,7 +166,7 @@ static struct m31_phy_regs m31_ipq5332_regs[] = {
164166
},
165167
{
166168
USB2PHY_USB_PHY_M31_XCFGI_4,
167-
HSTX_SLEW_RATE_565PS | PLL_CHARGING_PUMP_CURRENT_35UA | ODT_VALUE_38_02_OHM,
169+
HSTX_SLEW_RATE_400PS | PLL_CHARGING_PUMP_CURRENT_35UA | ODT_VALUE_38_02_OHM,
168170
0
169171
},
170172
{
@@ -174,9 +176,13 @@ static struct m31_phy_regs m31_ipq5332_regs[] = {
174176
},
175177
{
176178
USB2PHY_USB_PHY_M31_XCFGI_5,
177-
ODT_VALUE_45_02_OHM | HSTX_PRE_EMPHASIS_LEVEL_0_55MA,
179+
HSTX_PRE_EMPHASIS_LEVEL_0_55MA,
178180
4
179181
},
182+
{
183+
USB2PHY_USB_PHY_M31_XCFGI_9,
184+
HSTX_CURRENT_17_1MA_385MV,
185+
},
180186
{
181187
USB_PHY_UTMI_CTRL5,
182188
0x0,

0 commit comments

Comments
 (0)