Skip to content

Commit 5b27388

Browse files
mjruhlij-intel
authored andcommitted
drm/xe: Correct BMG VSEC header sizing
The intel_vsec_header information for the crashlog feature is incorrect. Update the VSEC header with correct sizing and count. Since the crashlog entries are "merged" (num_entries = 2), the separate capabilities entries must be merged as well. Fixes: 0c45e76 ("drm/xe/vsec: Support BMG devices") Acked-by: Rodrigo Vivi <[email protected]> Signed-off-by: Michael J. Ruhl <[email protected]> Reviewed-by: David E. Box <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Ilpo Järvinen <[email protected]>
1 parent 0ba9e9c commit 5b27388

File tree

1 file changed

+4
-15
lines changed

1 file changed

+4
-15
lines changed

drivers/gpu/drm/xe/xe_vsec.c

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -33,30 +33,19 @@ static struct intel_vsec_header bmg_telemetry = {
3333
.offset = BMG_DISCOVERY_OFFSET,
3434
};
3535

36-
static struct intel_vsec_header bmg_punit_crashlog = {
36+
static struct intel_vsec_header bmg_crashlog = {
3737
.rev = 1,
3838
.length = 0x10,
3939
.id = VSEC_ID_CRASHLOG,
40-
.num_entries = 1,
41-
.entry_size = 4,
40+
.num_entries = 2,
41+
.entry_size = 6,
4242
.tbir = 0,
4343
.offset = BMG_DISCOVERY_OFFSET + 0x60,
4444
};
4545

46-
static struct intel_vsec_header bmg_oobmsm_crashlog = {
47-
.rev = 1,
48-
.length = 0x10,
49-
.id = VSEC_ID_CRASHLOG,
50-
.num_entries = 1,
51-
.entry_size = 4,
52-
.tbir = 0,
53-
.offset = BMG_DISCOVERY_OFFSET + 0x78,
54-
};
55-
5646
static struct intel_vsec_header *bmg_capabilities[] = {
5747
&bmg_telemetry,
58-
&bmg_punit_crashlog,
59-
&bmg_oobmsm_crashlog,
48+
&bmg_crashlog,
6049
NULL
6150
};
6251

0 commit comments

Comments
 (0)