Skip to content

Commit 5d3aeec

Browse files
Bartosz Golaszewskiarndb
authored andcommitted
ARM: sa110/gpio: convert set_multiple() to returning an integer
The conversion to using the new GPIO line setter callbacks missed the set_multiple() in this file. Convert it to using the new callback. Fixes: 9c37821 ("ARM: sa1100/gpio: use new line value setter callbacks") Signed-off-by: Bartosz Golaszewski <[email protected]> Signed-off-by: Arnd Bergmann <[email protected]>
1 parent 990cd3e commit 5d3aeec

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

arch/arm/common/sa1111.c

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -578,8 +578,8 @@ static int sa1111_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)
578578
return 0;
579579
}
580580

581-
static void sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
582-
unsigned long *bits)
581+
static int sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
582+
unsigned long *bits)
583583
{
584584
struct sa1111 *sachip = gc_to_sa1111(gc);
585585
unsigned long flags;
@@ -597,6 +597,8 @@ static void sa1111_gpio_set_multiple(struct gpio_chip *gc, unsigned long *mask,
597597
sa1111_gpio_modify(reg + SA1111_GPIO_PCDWR, (msk >> 12) & 255, val >> 12);
598598
sa1111_gpio_modify(reg + SA1111_GPIO_PCSSR, (msk >> 12) & 255, val >> 12);
599599
spin_unlock_irqrestore(&sachip->lock, flags);
600+
601+
return 0;
600602
}
601603

602604
static int sa1111_gpio_to_irq(struct gpio_chip *gc, unsigned offset)
@@ -616,7 +618,7 @@ static int sa1111_setup_gpios(struct sa1111 *sachip)
616618
sachip->gc.direction_output = sa1111_gpio_direction_output;
617619
sachip->gc.get = sa1111_gpio_get;
618620
sachip->gc.set_rv = sa1111_gpio_set;
619-
sachip->gc.set_multiple = sa1111_gpio_set_multiple;
621+
sachip->gc.set_multiple_rv = sa1111_gpio_set_multiple;
620622
sachip->gc.to_irq = sa1111_gpio_to_irq;
621623
sachip->gc.base = -1;
622624
sachip->gc.ngpio = 18;

0 commit comments

Comments
 (0)