Skip to content

Commit 5ef7fdf

Browse files
committed
selftests: net: packetdrill: xfail all problems on slow machines
We keep seeing flakes on packetdrill on debug kernels, while non-debug kernels are stable, not a single flake in 200 runs. Time to give up, debug kernels appear to suffer from 10msec latency spikes and any timing-sensitive test is bound to flake. Reviewed-by: Willem de Bruijn <[email protected]> Acked-by: Matthieu Baerts (NGI0) <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 01d3c84 commit 5ef7fdf

File tree

1 file changed

+1
-18
lines changed

1 file changed

+1
-18
lines changed

tools/testing/selftests/net/packetdrill/ksft_runner.sh

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -35,24 +35,7 @@ failfunc=ktap_test_fail
3535

3636
if [[ -n "${KSFT_MACHINE_SLOW}" ]]; then
3737
optargs+=('--tolerance_usecs=14000')
38-
39-
# xfail tests that are known flaky with dbg config, not fixable.
40-
# still run them for coverage (and expect 100% pass without dbg).
41-
declare -ar xfail_list=(
42-
"tcp_blocking_blocking-connect.pkt"
43-
"tcp_blocking_blocking-read.pkt"
44-
"tcp_eor_no-coalesce-retrans.pkt"
45-
"tcp_fast_recovery_prr-ss.*.pkt"
46-
"tcp_sack_sack-route-refresh-ip-tos.pkt"
47-
"tcp_slow_start_slow-start-after-win-update.pkt"
48-
"tcp_timestamping.*.pkt"
49-
"tcp_user_timeout_user-timeout-probe.pkt"
50-
"tcp_zerocopy_cl.*.pkt"
51-
"tcp_zerocopy_epoll_.*.pkt"
52-
"tcp_tcp_info_tcp-info-.*-limited.pkt"
53-
)
54-
readonly xfail_regex="^($(printf '%s|' "${xfail_list[@]}"))$"
55-
[[ "$script" =~ ${xfail_regex} ]] && failfunc=ktap_test_xfail
38+
failfunc=ktap_test_xfail
5639
fi
5740

5841
ktap_print_header

0 commit comments

Comments
 (0)