Skip to content

Commit 65702c3

Browse files
jhovoldandersson
authored andcommitted
soc: qcom: pmic_glink: fix OF node leak
Make sure to drop the OF node reference taken when registering the auxiliary devices when the devices are later released. Fixes: 58ef4ec ("soc: qcom: pmic_glink: Introduce base PMIC GLINK driver") Cc: Bjorn Andersson <[email protected]> Signed-off-by: Johan Hovold <[email protected]> Reviewed-by: Konrad Dybcio <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 50b749f commit 65702c3

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

drivers/soc/qcom/pmic_glink.c

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,10 @@ static int pmic_glink_rpmsg_callback(struct rpmsg_device *rpdev, void *data,
167167
return 0;
168168
}
169169

170-
static void pmic_glink_aux_release(struct device *dev) {}
170+
static void pmic_glink_aux_release(struct device *dev)
171+
{
172+
of_node_put(dev->of_node);
173+
}
171174

172175
static int pmic_glink_add_aux_device(struct pmic_glink *pg,
173176
struct auxiliary_device *aux,
@@ -181,8 +184,10 @@ static int pmic_glink_add_aux_device(struct pmic_glink *pg,
181184
aux->dev.release = pmic_glink_aux_release;
182185
device_set_of_node_from_dev(&aux->dev, parent);
183186
ret = auxiliary_device_init(aux);
184-
if (ret)
187+
if (ret) {
188+
of_node_put(aux->dev.of_node);
185189
return ret;
190+
}
186191

187192
ret = auxiliary_device_add(aux);
188193
if (ret)

0 commit comments

Comments
 (0)