Skip to content

Commit 77de19b

Browse files
chaseyuJaegeuk Kim
authored andcommitted
f2fs: fix to avoid out-of-boundary access in dnode page
As Jiaming Zhang reported: <TASK> __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x1c1/0x2a0 lib/dump_stack.c:120 print_address_description mm/kasan/report.c:378 [inline] print_report+0x17e/0x800 mm/kasan/report.c:480 kasan_report+0x147/0x180 mm/kasan/report.c:593 data_blkaddr fs/f2fs/f2fs.h:3053 [inline] f2fs_data_blkaddr fs/f2fs/f2fs.h:3058 [inline] f2fs_get_dnode_of_data+0x1a09/0x1c40 fs/f2fs/node.c:855 f2fs_reserve_block+0x53/0x310 fs/f2fs/data.c:1195 prepare_write_begin fs/f2fs/data.c:3395 [inline] f2fs_write_begin+0xf39/0x2190 fs/f2fs/data.c:3594 generic_perform_write+0x2c7/0x910 mm/filemap.c:4112 f2fs_buffered_write_iter fs/f2fs/file.c:4988 [inline] f2fs_file_write_iter+0x1ec8/0x2410 fs/f2fs/file.c:5216 new_sync_write fs/read_write.c:593 [inline] vfs_write+0x546/0xa90 fs/read_write.c:686 ksys_write+0x149/0x250 fs/read_write.c:738 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xf3/0x3d0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f The root cause is in the corrupted image, there is a dnode has the same node id w/ its inode, so during f2fs_get_dnode_of_data(), it tries to access block address in dnode at offset 934, however it parses the dnode as inode node, so that get_dnode_addr() returns 360, then it tries to access page address from 360 + 934 * 4 = 4096 w/ 4 bytes. To fix this issue, let's add sanity check for node id of all direct nodes during f2fs_get_dnode_of_data(). Cc: [email protected] Reported-by: Jiaming Zhang <[email protected]> Closes: https://groups.google.com/g/syzkaller/c/-ZnaaOOfO3M Signed-off-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent 94b3ce7 commit 77de19b

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

fs/f2fs/node.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -815,6 +815,16 @@ int f2fs_get_dnode_of_data(struct dnode_of_data *dn, pgoff_t index, int mode)
815815
for (i = 1; i <= level; i++) {
816816
bool done = false;
817817

818+
if (nids[i] && nids[i] == dn->inode->i_ino) {
819+
err = -EFSCORRUPTED;
820+
f2fs_err_ratelimited(sbi,
821+
"inode mapping table is corrupted, run fsck to fix it, "
822+
"ino:%lu, nid:%u, level:%d, offset:%d",
823+
dn->inode->i_ino, nids[i], level, offset[level]);
824+
set_sbi_flag(sbi, SBI_NEED_FSCK);
825+
goto release_pages;
826+
}
827+
818828
if (!nids[i] && mode == ALLOC_NODE) {
819829
/* alloc new node */
820830
if (!f2fs_alloc_nid(sbi, &(nids[i]))) {

0 commit comments

Comments
 (0)