Skip to content

Commit 832ecb0

Browse files
superm1Jiri Kosina
authored andcommitted
HID: amd_sfh: Default to HPD disabled
Unless you know to look for it, HPD is a surprising behavior; particularly because it can wake the system from suspend. It also has implications for power consumption because sensors are left enabled. After the sensors have been probed (and HPD is found present), explicitly turn off HPD by default. Userspace can manually turn it on if desirable. Cc: Pratap Nirujogi <[email protected]> Tested-by: Anson Tsao <[email protected]> Signed-off-by: Mario Limonciello <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent e38764f commit 832ecb0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/hid/amd-sfh-hid/sfh1_1/amd_sfh_init.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,7 @@ static int amd_sfh1_1_hid_client_init(struct amd_mp2_dev *privdata)
213213
case HPD_IDX:
214214
privdata->dev_en.is_hpd_present = true;
215215
privdata->dev_en.is_hpd_enabled = true;
216+
amd_sfh_toggle_hpd(privdata, false);
216217
break;
217218
case ALS_IDX:
218219
privdata->dev_en.is_als_present = true;

0 commit comments

Comments
 (0)