Skip to content

Commit 8cb70b9

Browse files
author
Andreas Gruenbacher
committed
gfs2: some comment clarifications
Since commit e1fa9ea ("gfs2: Stop using glock holder auto-demotion for now"), we unconditionally drop the inode glock before trying to fault in more pages. Signed-off-by: Andreas Gruenbacher <[email protected]>
1 parent 951d701 commit 8cb70b9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

fs/gfs2/file.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -820,7 +820,7 @@ static ssize_t gfs2_file_direct_read(struct kiocb *iocb, struct iov_iter *to,
820820
/*
821821
* In this function, we disable page faults when we're holding the
822822
* inode glock while doing I/O. If a page fault occurs, we indicate
823-
* that the inode glock may be dropped, fault in the pages manually,
823+
* that the inode glock should be dropped, fault in the pages manually,
824824
* and retry.
825825
*
826826
* Unlike generic_file_read_iter, for reads, iomap_dio_rw can trigger
@@ -885,7 +885,7 @@ static ssize_t gfs2_file_direct_write(struct kiocb *iocb, struct iov_iter *from,
885885
/*
886886
* In this function, we disable page faults when we're holding the
887887
* inode glock while doing I/O. If a page fault occurs, we indicate
888-
* that the inode glock may be dropped, fault in the pages manually,
888+
* that the inode glock should be dropped, fault in the pages manually,
889889
* and retry.
890890
*
891891
* For writes, iomap_dio_rw only triggers manual page faults, so we
@@ -957,7 +957,7 @@ static ssize_t gfs2_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
957957
/*
958958
* In this function, we disable page faults when we're holding the
959959
* inode glock while doing I/O. If a page fault occurs, we indicate
960-
* that the inode glock may be dropped, fault in the pages manually,
960+
* that the inode glock should be dropped, fault in the pages manually,
961961
* and retry.
962962
*/
963963

@@ -1024,7 +1024,7 @@ static ssize_t gfs2_file_buffered_write(struct kiocb *iocb,
10241024
/*
10251025
* In this function, we disable page faults when we're holding the
10261026
* inode glock while doing I/O. If a page fault occurs, we indicate
1027-
* that the inode glock may be dropped, fault in the pages manually,
1027+
* that the inode glock should be dropped, fault in the pages manually,
10281028
* and retry.
10291029
*/
10301030

0 commit comments

Comments
 (0)