Skip to content

Commit 8cbe564

Browse files
tobluxtiwai
authored andcommitted
ALSA: intel_hdmi: Fix off-by-one error in __hdmi_lpe_audio_probe()
In __hdmi_lpe_audio_probe(), strscpy() is incorrectly called with the length of the source string (excluding the NUL terminator) rather than the size of the destination buffer. This results in one character less being copied from 'card->shortname' to 'pcm->name'. Use the destination buffer size instead to ensure the card name is copied correctly. Cc: [email protected] Fixes: 75b1a8f ("ALSA: Convert strlcpy to strscpy when return value is unused") Signed-off-by: Thorsten Blum <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
1 parent dbe0542 commit 8cbe564

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

sound/x86/intel_hdmi_audio.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1765,7 +1765,7 @@ static int __hdmi_lpe_audio_probe(struct platform_device *pdev)
17651765
/* setup private data which can be retrieved when required */
17661766
pcm->private_data = ctx;
17671767
pcm->info_flags = 0;
1768-
strscpy(pcm->name, card->shortname, strlen(card->shortname));
1768+
strscpy(pcm->name, card->shortname, sizeof(pcm->name));
17691769
/* setup the ops for playback */
17701770
snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &had_pcm_ops);
17711771

0 commit comments

Comments
 (0)