Skip to content

Commit 9697ca0

Browse files
oberparmartinkpetersen
authored andcommitted
scsi: s390: zfcp: Ensure synchronous unit_add
Improve the usability of the unit_add sysfs attribute by ensuring that the associated FCP LUN scan processing is completed synchronously. This enables configuration tooling to consistently determine the end of the scan process to allow for serialization of follow-on actions. While the scan process associated with unit_add typically completes synchronously, it is deferred to an asynchronous background process if unit_add is used before initial remote port scanning has completed. This occurs when unit_add is used immediately after setting the associated FCP device online. To ensure synchronous unit_add processing, wait for remote port scanning to complete before initiating the FCP LUN scan. Cc: [email protected] Reviewed-by: M Nikhil <[email protected]> Reviewed-by: Nihar Panda <[email protected]> Signed-off-by: Peter Oberparleiter <[email protected]> Signed-off-by: Nihar Panda <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 9b17621 commit 9697ca0

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/s390/scsi/zfcp_sysfs.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,8 @@ static ssize_t zfcp_sysfs_unit_add_store(struct device *dev,
449449
if (kstrtoull(buf, 0, (unsigned long long *) &fcp_lun))
450450
return -EINVAL;
451451

452+
flush_work(&port->rport_work);
453+
452454
retval = zfcp_unit_add(port, fcp_lun);
453455
if (retval)
454456
return retval;

0 commit comments

Comments
 (0)