Skip to content

Commit 9b71d26

Browse files
dlechjic23
authored andcommitted
iio: ABI: fix correctness of I and Q modifiers
Update the IIO ABI documentation to reflect the actual usage of channels with I and Q modifiers. These are currently only used in a few drivers: frequency/admv1013 (kernel v5.17): - in_altvoltageY-altvoltageZ_i_calibphase - in_altvoltageY-altvoltageZ_q_calibphase - in_altvoltageY_i_calibbias - in_altvoltageY_q_calibbias frequency/admv1014 (kernel v5.18): - in_altvoltageY_i_phase - in_altvoltageY_q_phase - in_altvoltageY_i_offset - in_altvoltageY_q_offset - in_altvoltageY_i_calibscale_course - in_altvoltageY_i_calibscale_fine - in_altvoltageY_q_calibscale_course - in_altvoltageY_q_calibscale_fine frequency/adrf6780 (kernel v5.16): - out_altvoltageY_i_phase - out_altvoltageY_q_phase There are no _raw or _scale attributes in use, so those are all removed. There are no currentY attributes in use with these modifiers, so those are also removed. All of the voltageY are changed to altvoltageY since that is how they are actually used. None of these channels are used with scan buffers, so all of those attributes are removed as well. And the {in,out}_altvoltageY_{i,q}_phase attributes were missing so those are added. The differential channel names for admv1013 are fixed. Signed-off-by: David Lechner <[email protected]> Reviewed-by: Nuno Sá <[email protected]> Link: https://patch.msgid.link/20250711-iio-abi-fix-i-and-q-modifiers-v1-1-35963c9c8c01@baylibre.com Signed-off-by: Jonathan Cameron <[email protected]>
1 parent e3d455d commit 9b71d26

File tree

3 files changed

+8
-46
lines changed

3 files changed

+8
-46
lines changed

Documentation/ABI/obsolete/sysfs-bus-iio

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@ What: /sys/.../iio:deviceX/scan_elements/in_timestamp_en
4848
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_supply_en
4949
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_en
5050
What: /sys/.../iio:deviceX/scan_elements/in_voltageY-voltageZ_en
51-
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_i_en
52-
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_q_en
53-
What: /sys/.../iio:deviceX/scan_elements/in_voltage_i_en
54-
What: /sys/.../iio:deviceX/scan_elements/in_voltage_q_en
5551
What: /sys/.../iio:deviceX/scan_elements/in_incli_x_en
5652
What: /sys/.../iio:deviceX/scan_elements/in_incli_y_en
5753
What: /sys/.../iio:deviceX/scan_elements/in_pressureY_en
@@ -73,10 +69,6 @@ What: /sys/.../iio:deviceX/scan_elements/in_incli_type
7369
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_type
7470
What: /sys/.../iio:deviceX/scan_elements/in_voltage_type
7571
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_supply_type
76-
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_i_type
77-
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_q_type
78-
What: /sys/.../iio:deviceX/scan_elements/in_voltage_i_type
79-
What: /sys/.../iio:deviceX/scan_elements/in_voltage_q_type
8072
What: /sys/.../iio:deviceX/scan_elements/in_timestamp_type
8173
What: /sys/.../iio:deviceX/scan_elements/in_pressureY_type
8274
What: /sys/.../iio:deviceX/scan_elements/in_pressure_type
@@ -110,10 +102,6 @@ Description:
110102

111103
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_index
112104
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_supply_index
113-
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_i_index
114-
What: /sys/.../iio:deviceX/scan_elements/in_voltageY_q_index
115-
What: /sys/.../iio:deviceX/scan_elements/in_voltage_i_index
116-
What: /sys/.../iio:deviceX/scan_elements/in_voltage_q_index
117105
What: /sys/.../iio:deviceX/scan_elements/in_accel_x_index
118106
What: /sys/.../iio:deviceX/scan_elements/in_accel_y_index
119107
What: /sys/.../iio:deviceX/scan_elements/in_accel_z_index

Documentation/ABI/testing/sysfs-bus-iio

Lines changed: 6 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,6 @@ Description:
141141

142142
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_raw
143143
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_supply_raw
144-
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_i_raw
145-
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_q_raw
146144
KernelVersion: 2.6.35
147145
148146
Description:
@@ -417,18 +415,14 @@ What: /sys/bus/iio/devices/iio:deviceX/in_accel_offset
417415
What: /sys/bus/iio/devices/iio:deviceX/in_accel_x_offset
418416
What: /sys/bus/iio/devices/iio:deviceX/in_accel_y_offset
419417
What: /sys/bus/iio/devices/iio:deviceX/in_accel_z_offset
418+
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage_q_offset
419+
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage_i_offset
420420
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_offset
421421
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_offset
422422
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_i_offset
423423
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_q_offset
424-
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_q_offset
425-
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_i_offset
426424
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_offset
427425
What: /sys/bus/iio/devices/iio:deviceX/in_current_offset
428-
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_i_offset
429-
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_q_offset
430-
What: /sys/bus/iio/devices/iio:deviceX/in_current_q_offset
431-
What: /sys/bus/iio/devices/iio:deviceX/in_current_i_offset
432426
What: /sys/bus/iio/devices/iio:deviceX/in_tempY_offset
433427
What: /sys/bus/iio/devices/iio:deviceX/in_temp_offset
434428
What: /sys/bus/iio/devices/iio:deviceX/in_pressureY_offset
@@ -456,21 +450,15 @@ Description:
456450
to the _raw output.
457451

458452
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_scale
459-
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_i_scale
460453
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_q_scale
461454
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_supply_scale
462455
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_scale
463-
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_i_scale
464-
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_q_scale
465456
What: /sys/bus/iio/devices/iio:deviceX/in_voltage-voltage_scale
466457
What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_scale
467458
What: /sys/bus/iio/devices/iio:deviceX/out_altvoltageY_scale
468459
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_scale
469460
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_supply_scale
470461
What: /sys/bus/iio/devices/iio:deviceX/in_current_scale
471-
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_i_scale
472-
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_q_scale
473-
What: /sys/bus/iio/devices/iio:deviceX/in_current_i_scale
474462
What: /sys/bus/iio/devices/iio:deviceX/in_current_q_scale
475463
What: /sys/bus/iio/devices/iio:deviceX/in_accel_scale
476464
What: /sys/bus/iio/devices/iio:deviceX/in_accel_peak_scale
@@ -603,11 +591,7 @@ What: /sys/bus/iio/devices/iio:deviceX/in_pressure_calibscale
603591
What: /sys/bus/iio/devices/iio:deviceX/in_pressureY_calibscale
604592
What: /sys/bus/iio/devices/iio:deviceX/in_proximity0_calibscale
605593
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_calibscale
606-
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_i_calibscale
607-
What: /sys/bus/iio/devices/iio:deviceX/in_voltage_q_calibscale
608594
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_calibscale
609-
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_i_calibscale
610-
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_q_calibscale
611595
What: /sys/bus/iio/devices/iio:deviceX/in_voltageY_supply_calibscale
612596
What: /sys/bus/iio/devices/iio:deviceX/out_currentY_calibscale
613597
What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_calibscale
@@ -829,7 +813,11 @@ Description:
829813
all the other channels, since it involves changing the VCO
830814
fundamental output frequency.
831815

816+
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltageY_i_phase
817+
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltageY_q_phase
832818
What: /sys/bus/iio/devices/iio:deviceX/out_altvoltageY_phase
819+
What: /sys/bus/iio/devices/iio:deviceX/out_altvoltageY_i_phase
820+
What: /sys/bus/iio/devices/iio:deviceX/out_altvoltageY_q_phase
833821
KernelVersion: 3.4.0
834822
835823
Description:
@@ -1458,10 +1446,6 @@ What: /sys/.../iio:deviceX/bufferY/in_timestamp_en
14581446
What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_en
14591447
What: /sys/.../iio:deviceX/bufferY/in_voltageY_en
14601448
What: /sys/.../iio:deviceX/bufferY/in_voltageY-voltageZ_en
1461-
What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_en
1462-
What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_en
1463-
What: /sys/.../iio:deviceX/bufferY/in_voltage_i_en
1464-
What: /sys/.../iio:deviceX/bufferY/in_voltage_q_en
14651449
What: /sys/.../iio:deviceX/bufferY/in_incli_x_en
14661450
What: /sys/.../iio:deviceX/bufferY/in_incli_y_en
14671451
What: /sys/.../iio:deviceX/bufferY/in_pressureY_en
@@ -1482,10 +1466,6 @@ What: /sys/.../iio:deviceX/bufferY/in_incli_type
14821466
What: /sys/.../iio:deviceX/bufferY/in_voltageY_type
14831467
What: /sys/.../iio:deviceX/bufferY/in_voltage_type
14841468
What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_type
1485-
What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_type
1486-
What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_type
1487-
What: /sys/.../iio:deviceX/bufferY/in_voltage_i_type
1488-
What: /sys/.../iio:deviceX/bufferY/in_voltage_q_type
14891469
What: /sys/.../iio:deviceX/bufferY/in_timestamp_type
14901470
What: /sys/.../iio:deviceX/bufferY/in_pressureY_type
14911471
What: /sys/.../iio:deviceX/bufferY/in_pressure_type
@@ -1523,10 +1503,6 @@ Description:
15231503

15241504
What: /sys/.../iio:deviceX/bufferY/in_voltageY_index
15251505
What: /sys/.../iio:deviceX/bufferY/in_voltageY_supply_index
1526-
What: /sys/.../iio:deviceX/bufferY/in_voltageY_i_index
1527-
What: /sys/.../iio:deviceX/bufferY/in_voltageY_q_index
1528-
What: /sys/.../iio:deviceX/bufferY/in_voltage_i_index
1529-
What: /sys/.../iio:deviceX/bufferY/in_voltage_q_index
15301506
What: /sys/.../iio:deviceX/bufferY/in_accel_x_index
15311507
What: /sys/.../iio:deviceX/bufferY/in_accel_y_index
15321508
What: /sys/.../iio:deviceX/bufferY/in_accel_z_index
@@ -1716,8 +1692,6 @@ Description:
17161692

17171693
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_raw
17181694
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_supply_raw
1719-
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_i_raw
1720-
What: /sys/bus/iio/devices/iio:deviceX/in_currentY_q_raw
17211695
KernelVersion: 3.17
17221696
17231697
Description:

Documentation/ABI/testing/sysfs-bus-iio-frequency-admv1013

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0-1_i_calibphase
1+
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0-altvoltage1_i_calibphase
22
KernelVersion:
33
44
Description:
55
Read/write unscaled value for the Local Oscillatior path quadrature I phase shift.
66

7-
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0-1_q_calibphase
7+
What: /sys/bus/iio/devices/iio:deviceX/in_altvoltage0-altvoltage1_q_calibphase
88
KernelVersion:
99
1010
Description:

0 commit comments

Comments
 (0)