Skip to content

Commit 9e3d138

Browse files
Matthew Wilcox (Oracle)Jaegeuk Kim
authored andcommitted
f2fs: Pass a folio to f2fs_is_compressed_page()
All callers now have a folio so pass it in. Also remove the test for the private flag; it is redundant with checking folio->private for being NULL. Signed-off-by: Matthew Wilcox (Oracle) <[email protected]> Reviewed-by: Chao Yu <[email protected]> Signed-off-by: Jaegeuk Kim <[email protected]>
1 parent cabda16 commit 9e3d138

File tree

3 files changed

+13
-15
lines changed

3 files changed

+13
-15
lines changed

fs/f2fs/compress.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -71,17 +71,15 @@ static pgoff_t start_idx_of_cluster(struct compress_ctx *cc)
7171
return cc->cluster_idx << cc->log_cluster_size;
7272
}
7373

74-
bool f2fs_is_compressed_page(struct page *page)
74+
bool f2fs_is_compressed_page(struct folio *folio)
7575
{
76-
if (!PagePrivate(page))
76+
if (!folio->private)
7777
return false;
78-
if (!page_private(page))
79-
return false;
80-
if (page_private_nonpointer(page))
78+
if (folio_test_f2fs_nonpointer(folio))
8179
return false;
8280

83-
f2fs_bug_on(F2FS_P_SB(page),
84-
*((u32 *)page_private(page)) != F2FS_COMPRESSED_PAGE_MAGIC);
81+
f2fs_bug_on(F2FS_F_SB(folio),
82+
*((u32 *)folio->private) != F2FS_COMPRESSED_PAGE_MAGIC);
8583
return true;
8684
}
8785

@@ -1478,7 +1476,7 @@ void f2fs_compress_write_end_io(struct bio *bio, struct folio *folio)
14781476
struct f2fs_sb_info *sbi = bio->bi_private;
14791477
struct compress_io_ctx *cic = folio->private;
14801478
enum count_type type = WB_DATA_TYPE(folio,
1481-
f2fs_is_compressed_page(page));
1479+
f2fs_is_compressed_page(folio));
14821480
int i;
14831481

14841482
if (unlikely(bio->bi_status != BLK_STS_OK))

fs/f2fs/data.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ static void f2fs_finish_read_bio(struct bio *bio, bool in_task)
142142
bio_for_each_folio_all(fi, bio) {
143143
struct folio *folio = fi.folio;
144144

145-
if (f2fs_is_compressed_page(&folio->page)) {
145+
if (f2fs_is_compressed_page(folio)) {
146146
if (ctx && !ctx->decompression_attempted)
147147
f2fs_end_read_compressed_page(folio, true, 0,
148148
in_task);
@@ -186,7 +186,7 @@ static void f2fs_verify_bio(struct work_struct *work)
186186
bio_for_each_folio_all(fi, bio) {
187187
struct folio *folio = fi.folio;
188188

189-
if (!f2fs_is_compressed_page(&folio->page) &&
189+
if (!f2fs_is_compressed_page(folio) &&
190190
!fsverity_verify_page(&folio->page)) {
191191
bio->bi_status = BLK_STS_IOERR;
192192
break;
@@ -239,7 +239,7 @@ static void f2fs_handle_step_decompress(struct bio_post_read_ctx *ctx,
239239
bio_for_each_folio_all(fi, ctx->bio) {
240240
struct folio *folio = fi.folio;
241241

242-
if (f2fs_is_compressed_page(&folio->page))
242+
if (f2fs_is_compressed_page(folio))
243243
f2fs_end_read_compressed_page(folio, false, blkaddr,
244244
in_task);
245245
else
@@ -337,7 +337,7 @@ static void f2fs_write_end_io(struct bio *bio)
337337
}
338338

339339
#ifdef CONFIG_F2FS_FS_COMPRESSION
340-
if (f2fs_is_compressed_page(&folio->page)) {
340+
if (f2fs_is_compressed_page(folio)) {
341341
f2fs_compress_write_end_io(bio, folio);
342342
continue;
343343
}
@@ -561,7 +561,7 @@ static bool __has_merged_page(struct bio *bio, struct inode *inode,
561561
if (IS_ERR(target))
562562
continue;
563563
}
564-
if (f2fs_is_compressed_page(&target->page)) {
564+
if (f2fs_is_compressed_page(target)) {
565565
target = f2fs_compress_control_folio(target);
566566
if (IS_ERR(target))
567567
continue;

fs/f2fs/f2fs.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4474,7 +4474,7 @@ enum cluster_check_type {
44744474
CLUSTER_COMPR_BLKS, /* return # of compressed blocks in a cluster */
44754475
CLUSTER_RAW_BLKS /* return # of raw blocks in a cluster */
44764476
};
4477-
bool f2fs_is_compressed_page(struct page *page);
4477+
bool f2fs_is_compressed_page(struct folio *folio);
44784478
struct folio *f2fs_compress_control_folio(struct folio *folio);
44794479
int f2fs_prepare_compress_overwrite(struct inode *inode,
44804480
struct page **pagep, pgoff_t index, void **fsdata);
@@ -4543,7 +4543,7 @@ void f2fs_invalidate_compress_pages(struct f2fs_sb_info *sbi, nid_t ino);
45434543
sbi->compr_saved_block += diff; \
45444544
} while (0)
45454545
#else
4546-
static inline bool f2fs_is_compressed_page(struct page *page) { return false; }
4546+
static inline bool f2fs_is_compressed_page(struct folio *folio) { return false; }
45474547
static inline bool f2fs_is_compress_backend_ready(struct inode *inode)
45484548
{
45494549
if (!f2fs_compressed_file(inode))

0 commit comments

Comments
 (0)