Skip to content

Commit a4fa2e6

Browse files
AdityaGarg8Jiri Kosina
authored andcommitted
HID: hid-appletb-bl: use appletb_bl_brightness_map instead of magic numbers to set default brightness
This commit makes use of appletb_bl_brightness_map instead of using if statements and magic numbers to set default brightness, and thus simplifies the code. Signed-off-by: Aditya Garg <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent cc9714a commit a4fa2e6

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

drivers/hid/hid-appletb-bl.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,12 +141,8 @@ static int appletb_bl_probe(struct hid_device *hdev, const struct hid_device_id
141141
bl->aux1_field = aux1_field;
142142
bl->brightness_field = brightness_field;
143143

144-
if (appletb_bl_def_brightness == 0)
145-
ret = appletb_bl_set_brightness(bl, APPLETB_BL_OFF);
146-
else if (appletb_bl_def_brightness == 1)
147-
ret = appletb_bl_set_brightness(bl, APPLETB_BL_DIM);
148-
else
149-
ret = appletb_bl_set_brightness(bl, APPLETB_BL_ON);
144+
ret = appletb_bl_set_brightness(bl,
145+
appletb_bl_brightness_map[(appletb_bl_def_brightness > 2) ? 2 : appletb_bl_def_brightness]);
150146

151147
if (ret) {
152148
dev_err_probe(dev, ret, "Failed to set touch bar brightness to off\n");

0 commit comments

Comments
 (0)