Skip to content

Commit a8122a6

Browse files
lenticularis39rostedt
authored andcommitted
rtla/osnoise: Set OSNOISE_WORKLOAD to true
If running rtla osnoise with NO_OSNOISE_WORKLOAD, it reports no samples: $ echo NO_OSNOISE_WORKLOAD > /sys/kernel/tracing/osnoise/options $ rtla osnoise hist -d 10s Index over: 0 count: 0 min: 0 avg: 0 max: 0 This situation can also happen when running rtla-osnoise after an improperly exited rtla-timerlat run. Set OSNOISE_WORKLOAD in rtla-osnoise, too, similarly to what we already did for timerlat in commit 217f0b1 ("rtla/timerlat_top: Set OSNOISE_WORKLOAD for kernel threads") and commit d8d8661 ("rtla/timerlat_hist: Set OSNOISE_WORKLOAD for kernel threads"). Note that there is no user workload mode for rtla-osnoise yet, so OSNOISE_WORKLOAD is always set to true. Cc: Luis Goncalves <[email protected]> Link: https://lore.kernel.org/[email protected] Fixes: 1eceb2f ("rtla/osnoise: Add osnoise top mode") Fixes: 829a6c0 ("rtla/osnoise: Add the hist mode") Signed-off-by: Tomas Glozar <[email protected]> Reviewed-by: John Kacur <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent 20d6b07 commit a8122a6

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

tools/tracing/rtla/src/osnoise.c

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1187,6 +1187,12 @@ osnoise_apply_config(struct osnoise_tool *tool, struct osnoise_params *params)
11871187
auto_house_keeping(&params->monitored_cpus);
11881188
}
11891189

1190+
retval = osnoise_set_workload(tool->context, true);
1191+
if (retval < -1) {
1192+
err_msg("Failed to set OSNOISE_WORKLOAD option\n");
1193+
goto out_err;
1194+
}
1195+
11901196
return 0;
11911197

11921198
out_err:

0 commit comments

Comments
 (0)