Skip to content

Commit a86240a

Browse files
arndbBartosz Golaszewski
authored andcommitted
gpiolib: enable CONFIG_GPIOLIB_LEGACY even for !GPIOLIB
A few drivers that use the legacy GPIOLIB interfaces can be enabled even when GPIOLIB is disabled entirely. With my previous patch this now causes build failures like: drivers/nfc/s3fwrn5/uart.c: In function 's3fwrn82_uart_parse_dt': drivers/nfc/s3fwrn5/uart.c:100:14: error: implicit declaration of function 'gpio_is_valid'; did you mean 'uuid_is_valid'? [-Werror=implicit-function-declaration] These did not show up in my randconfig tests because randconfig almost always has GPIOLIB selected by some other driver, and I did most of the testing with follow-up patches that address the failures properly. Move the symbol outside of the 'if CONFIG_GPIOLIB' block for the moment to avoid the build failures. It can be moved back and turned off by default once all the driver specific changes are merged. Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Fixes: 678bae2 ("gpiolib: make legacy interfaces optional") Signed-off-by: Arnd Bergmann <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent 4740e1e commit a86240a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpio/Kconfig

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ menuconfig GPIOLIB
1212

1313
If unsure, say N.
1414

15-
if GPIOLIB
16-
1715
config GPIOLIB_LEGACY
1816
def_bool y
1917

18+
if GPIOLIB
19+
2020
config GPIOLIB_FASTPATH_LIMIT
2121
int "Maximum number of GPIOs for fast path"
2222
range 32 512

0 commit comments

Comments
 (0)