Skip to content

Commit a9635ef

Browse files
bleungatchromiumTzung-Bi Shih
authored andcommitted
platform/chrome: cros_ec_typec: Set Pin Assignment E in DP PORT VDO
Pin C and D are used on C-to-C cable applications including docks, and for USB-C adapters that convert from DP over USB-C to other video standards. Pin Assignment E is intended to be used with adapter from USB-C to DP plugs or receptacles. All Chromebook USB-C DFPs support DisplayPort Alternate Mode as the DP Source with support for all 3 pin assignments. Pin Assignment E is required in order to support if the user attaches a Pin E C-to-DP cable. Without this, the displayport.c alt mode driver will error out of dp_altmode_probe with an -ENODEV, as it cannot find a compatible matching pin assignment between the DFP_D and UFP_D. Fixes: dbb3fc0 ("platform/chrome: cros_ec_typec: Displayport support") Signed-off-by: Benson Leung <[email protected]> Reviewed-by: Jameson Thies <[email protected]> Reviewed-by: Abhishek Pandit-Subedi <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Tzung-Bi Shih <[email protected]>
1 parent fb8bfb4 commit a9635ef

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/platform/chrome/cros_ec_typec.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,10 @@
2222

2323
#define DRV_NAME "cros-ec-typec"
2424

25-
#define DP_PORT_VDO (DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | BIT(DP_PIN_ASSIGN_D)) | \
26-
DP_CAP_DFP_D | DP_CAP_RECEPTACLE)
25+
#define DP_PORT_VDO (DP_CAP_DFP_D | DP_CAP_RECEPTACLE | \
26+
DP_CONF_SET_PIN_ASSIGN(BIT(DP_PIN_ASSIGN_C) | \
27+
BIT(DP_PIN_ASSIGN_D) | \
28+
BIT(DP_PIN_ASSIGN_E)))
2729

2830
static void cros_typec_role_switch_quirk(struct fwnode_handle *fwnode)
2931
{

0 commit comments

Comments
 (0)