Skip to content

Commit b24bbb5

Browse files
kaihuangsean-jc
authored andcommitted
KVM: x86: Reject KVM_SET_TSC_KHZ vCPU ioctl for TSC protected guest
Reject KVM_SET_TSC_KHZ vCPU ioctl if guest's TSC is protected and not changeable by KVM, and update the documentation to reflect it. For such TSC protected guests, e.g. TDX guests, typically the TSC is configured once at VM level before any vCPU are created and remains unchanged during VM's lifetime. KVM provides the KVM_SET_TSC_KHZ VM scope ioctl to allow the userspace VMM to configure the TSC of such VM. After that the userspace VMM is not supposed to call the KVM_SET_TSC_KHZ vCPU scope ioctl anymore when creating the vCPU. The de facto userspace VMM Qemu does this for TDX guests. The upcoming SEV-SNP guests with Secure TSC should follow. Note, TDX support hasn't been fully released as of the "buggy" commit, i.e. there is no established ABI to break. Fixes: adafea1 ("KVM: x86: Add infrastructure for secure TSC") Suggested-by: Sean Christopherson <[email protected]> Signed-off-by: Kai Huang <[email protected]> Reviewed-by: Xiaoyao Li <[email protected]> Reviewed-by: Nikunj A Dadhania <[email protected]> Link: https://lore.kernel.org/r/71bbdf87fdd423e3ba3a45b57642c119ee2dd98c.1752444335.git.kai.huang@intel.com Signed-off-by: Sean Christopherson <[email protected]>
1 parent 073b3ec commit b24bbb5

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

Documentation/virt/kvm/api.rst

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2008,6 +2008,13 @@ If the KVM_CAP_VM_TSC_CONTROL capability is advertised, this can also
20082008
be used as a vm ioctl to set the initial tsc frequency of subsequently
20092009
created vCPUs.
20102010

2011+
For TSC protected Confidential Computing (CoCo) VMs where TSC frequency
2012+
is configured once at VM scope and remains unchanged during VM's
2013+
lifetime, the vm ioctl should be used to configure the TSC frequency
2014+
and the vcpu ioctl is not supported.
2015+
2016+
Example of such CoCo VMs: TDX guests.
2017+
20112018
4.56 KVM_GET_TSC_KHZ
20122019
--------------------
20132020

arch/x86/kvm/x86.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6188,6 +6188,10 @@ long kvm_arch_vcpu_ioctl(struct file *filp,
61886188
u32 user_tsc_khz;
61896189

61906190
r = -EINVAL;
6191+
6192+
if (vcpu->arch.guest_tsc_protected)
6193+
goto out;
6194+
61916195
user_tsc_khz = (u32)arg;
61926196

61936197
if (kvm_caps.has_tsc_control &&

0 commit comments

Comments
 (0)