Skip to content

Commit c464ce6

Browse files
vsyrjalajlahtine-intel
authored andcommitted
drm/i915/dsi: Fix off by one in BXT_MIPI_TRANS_VTOTAL
BXT_MIPI_TRANS_VTOTAL must be programmed with vtotal-1 instead of vtotal. Make it so. Cc: [email protected] Signed-off-by: Ville Syrjälä <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected] Reviewed-by: Jani Nikula <[email protected]> (cherry picked from commit 7b3685c) Signed-off-by: Joonas Lahtinen <[email protected]>
1 parent a7137b1 commit c464ce6

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/gpu/drm/i915/display/vlv_dsi.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,7 +1056,7 @@ static void bxt_dsi_get_pipe_config(struct intel_encoder *encoder,
10561056
BXT_MIPI_TRANS_VACTIVE(port));
10571057
adjusted_mode->crtc_vtotal =
10581058
intel_de_read(display,
1059-
BXT_MIPI_TRANS_VTOTAL(port));
1059+
BXT_MIPI_TRANS_VTOTAL(port)) + 1;
10601060

10611061
hactive = adjusted_mode->crtc_hdisplay;
10621062
hfp = intel_de_read(display, MIPI_HFP_COUNT(display, port));
@@ -1260,7 +1260,7 @@ static void set_dsi_timings(struct intel_encoder *encoder,
12601260
intel_de_write(display, BXT_MIPI_TRANS_VACTIVE(port),
12611261
adjusted_mode->crtc_vdisplay);
12621262
intel_de_write(display, BXT_MIPI_TRANS_VTOTAL(port),
1263-
adjusted_mode->crtc_vtotal);
1263+
adjusted_mode->crtc_vtotal - 1);
12641264
}
12651265

12661266
intel_de_write(display, MIPI_HACTIVE_AREA_COUNT(display, port),

0 commit comments

Comments
 (0)