Skip to content

Commit d2b87d9

Browse files
LegoLivesMatterarndb
authored andcommitted
dt-bindings: mmc: sdhci-pxa: restrict pinctrl to pxav1
The current pinctrl properties apply only to the pxav1 controller. Adding one default pinctrl node to a pxav3 controller therefore causes a schema warning. Check the existing properties only on pxav1. pxav2 and pxav3 may add their own set of pinctrl properties if and when needed. Signed-off-by: Duje Mihanović <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Arnd Bergmann <[email protected]>
1 parent 86731a2 commit d2b87d9

File tree

1 file changed

+20
-16
lines changed

1 file changed

+20
-16
lines changed

Documentation/devicetree/bindings/mmc/sdhci-pxa.yaml

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,26 @@ allOf:
3030
maxItems: 1
3131
reg-names:
3232
maxItems: 1
33+
- if:
34+
properties:
35+
compatible:
36+
contains:
37+
const: mrvl,pxav1-mmc
38+
then:
39+
properties:
40+
pinctrl-names:
41+
description:
42+
Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between
43+
SDIO CMD and GPIO mode.
44+
items:
45+
- const: default
46+
- const: state_cmd_gpio
47+
pinctrl-0:
48+
description:
49+
Should contain default pinctrl.
50+
pinctrl-1:
51+
description:
52+
Should switch CMD pin to GPIO mode as a high output.
3353

3454
properties:
3555
compatible:
@@ -62,22 +82,6 @@ properties:
6282
- const: io
6383
- const: core
6484

65-
pinctrl-names:
66-
description:
67-
Optional for supporting PXA168 SDIO IRQ errata to switch CMD pin between
68-
SDIO CMD and GPIO mode.
69-
items:
70-
- const: default
71-
- const: state_cmd_gpio
72-
73-
pinctrl-0:
74-
description:
75-
Should contain default pinctrl.
76-
77-
pinctrl-1:
78-
description:
79-
Should switch CMD pin to GPIO mode as a high output.
80-
8185
mrvl,clk-delay-cycles:
8286
description: Specify a number of cycles to delay for tuning.
8387
$ref: /schemas/types.yaml#/definitions/uint32

0 commit comments

Comments
 (0)