Skip to content

Commit d9c9115

Browse files
diederikdehaasmmind
authored andcommitted
arm64: dts: rockchip: Move dsi address+size-cells from SoC to rk3399 boards
The #address-cells and #size-cells properties are not useful on the DSI controller node; they are only useful/required on ports and panel(s). So remove them from the controller node and add them where actually needed on the various rk3399 based boards. This fixes the following DTB validation warnings: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property Signed-off-by: Diederik de Haas <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 98921ad commit d9c9115

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

arch/arm64/boot/dts/rockchip/rk3399-base.dtsi

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2071,8 +2071,6 @@
20712071
resets = <&cru SRST_P_MIPI_DSI0>;
20722072
reset-names = "apb";
20732073
rockchip,grf = <&grf>;
2074-
#address-cells = <1>;
2075-
#size-cells = <0>;
20762074
status = "disabled";
20772075

20782076
ports {
@@ -2112,8 +2110,6 @@
21122110
resets = <&cru SRST_P_MIPI_DSI1>;
21132111
reset-names = "apb";
21142112
rockchip,grf = <&grf>;
2115-
#address-cells = <1>;
2116-
#size-cells = <0>;
21172113
#phy-cells = <0>;
21182114
status = "disabled";
21192115

arch/arm64/boot/dts/rockchip/rk3399-gru-scarlet.dtsi

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -627,8 +627,10 @@ camera: &i2c7 {
627627
};
628628

629629
&mipi_dsi {
630-
status = "okay";
631630
clock-master;
631+
#address-cells = <1>;
632+
#size-cells = <0>;
633+
status = "okay";
632634

633635
ports {
634636
mipi_out: port@1 {

arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -587,6 +587,8 @@
587587

588588
&mipi_dsi {
589589
clock-master;
590+
#address-cells = <1>;
591+
#size-cells = <0>;
590592
status = "okay";
591593

592594
panel@0 {

arch/arm64/boot/dts/rockchip/rk3399-rockpro64-screen.dtso

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,10 +47,9 @@
4747
};
4848

4949
&mipi_dsi {
50+
clock-master;
5051
#address-cells = <1>;
5152
#size-cells = <0>;
52-
53-
clock-master;
5453
status = "okay";
5554

5655
ports {

0 commit comments

Comments
 (0)