Skip to content

Commit e82c78a

Browse files
lenticularis39rostedt
authored andcommitted
tools/rv: Keep user LDFLAGS in build
rv, unlike rtla and perf, drops LDFLAGS supplied by the user and honors only EXTRA_LDFLAGS. This is inconsistent with both perf and rtla and can lead to all kinds of unexpected behavior. For example, on Fedora and RHEL, it causes rv to be build without PIE, unlike the aforementioned perf and rtla: $ file /usr/bin/{rv,rtla,perf} /usr/bin/rv: ELF 64-bit LSB executable, ... /usr/bin/rtla: ELF 64-bit LSB pie executable, ... /usr/bin/perf: ELF 64-bit LSB pie executable, ... Keep both LDFLAGS and EXTRA_LDFLAGS for the build. Cc: John Kacur <[email protected]> Cc: Luis Goncalves <[email protected]> Cc: Gabriele Monaco <[email protected]> Link: https://lore.kernel.org/[email protected] Fixes: 012e4e7 ("tools/verification: Use tools/build makefiles on rv") Signed-off-by: Tomas Glozar <[email protected]> Signed-off-by: Steven Rostedt (Google) <[email protected]>
1 parent 005682b commit e82c78a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/verification/rv/Makefile.rv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ endif
2727

2828
INCLUDE := -Iinclude/
2929
CFLAGS := -g -DVERSION=\"$(VERSION)\" $(FOPTS) $(WOPTS) $(EXTRA_CFLAGS) $(INCLUDE)
30-
LDFLAGS := -ggdb $(EXTRA_LDFLAGS)
30+
LDFLAGS := -ggdb $(LDFLAGS) $(EXTRA_LDFLAGS)
3131

3232
INSTALL := install
3333
MKDIR := mkdir

0 commit comments

Comments
 (0)