Skip to content

Commit f2792bf

Browse files
Kwiboommind
authored andcommitted
arm64: dts: rockchip: Fix pinctrl node names for RK3528
Following warnings can be observed with CHECK_DTBS=y for the RK3528: rk3528-pinctrl.dtsi:101.36-105.5: Warning (node_name_chars_strict): /pinctrl/fephy/fephym0-led_dpx: Character '_' not recommended in node name rk3528-pinctrl.dtsi:108.38-112.5: Warning (node_name_chars_strict): /pinctrl/fephy/fephym0-led_link: Character '_' not recommended in node name rk3528-pinctrl.dtsi:115.36-119.5: Warning (node_name_chars_strict): /pinctrl/fephy/fephym0-led_spd: Character '_' not recommended in node name rk3528-pinctrl.dtsi:122.36-126.5: Warning (node_name_chars_strict): /pinctrl/fephy/fephym1-led_dpx: Character '_' not recommended in node name rk3528-pinctrl.dtsi:129.38-133.5: Warning (node_name_chars_strict): /pinctrl/fephy/fephym1-led_link: Character '_' not recommended in node name rk3528-pinctrl.dtsi:136.36-140.5: Warning (node_name_chars_strict): /pinctrl/fephy/fephym1-led_spd: Character '_' not recommended in node name rk3528-pinctrl.dtsi:782.32-790.5: Warning (node_name_chars_strict): /pinctrl/rgmii/rgmii-rx_bus2: Character '_' not recommended in node name rk3528-pinctrl.dtsi:793.32-801.5: Warning (node_name_chars_strict): /pinctrl/rgmii/rgmii-tx_bus2: Character '_' not recommended in node name rk3528-pinctrl.dtsi:804.36-810.5: Warning (node_name_chars_strict): /pinctrl/rgmii/rgmii-rgmii_clk: Character '_' not recommended in node name rk3528-pinctrl.dtsi:813.36-823.5: Warning (node_name_chars_strict): /pinctrl/rgmii/rgmii-rgmii_bus: Character '_' not recommended in node name Rename the affected nodes to fix these warnings. Fixes: a31fad1 ("arm64: dts: rockchip: Add pinctrl and gpio nodes for RK3528") Signed-off-by: Jonas Karlman <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Heiko Stuebner <[email protected]>
1 parent 96cbdfd commit f2792bf

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

arch/arm64/boot/dts/rockchip/rk3528-pinctrl.dtsi

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -98,42 +98,42 @@
9898

9999
fephy {
100100
/omit-if-no-ref/
101-
fephym0_led_dpx: fephym0-led_dpx {
101+
fephym0_led_dpx: fephym0-led-dpx {
102102
rockchip,pins =
103103
/* fephy_led_dpx_m0 */
104104
<4 RK_PB5 2 &pcfg_pull_none>;
105105
};
106106

107107
/omit-if-no-ref/
108-
fephym0_led_link: fephym0-led_link {
108+
fephym0_led_link: fephym0-led-link {
109109
rockchip,pins =
110110
/* fephy_led_link_m0 */
111111
<4 RK_PC0 2 &pcfg_pull_none>;
112112
};
113113

114114
/omit-if-no-ref/
115-
fephym0_led_spd: fephym0-led_spd {
115+
fephym0_led_spd: fephym0-led-spd {
116116
rockchip,pins =
117117
/* fephy_led_spd_m0 */
118118
<4 RK_PB7 2 &pcfg_pull_none>;
119119
};
120120

121121
/omit-if-no-ref/
122-
fephym1_led_dpx: fephym1-led_dpx {
122+
fephym1_led_dpx: fephym1-led-dpx {
123123
rockchip,pins =
124124
/* fephy_led_dpx_m1 */
125125
<2 RK_PA4 5 &pcfg_pull_none>;
126126
};
127127

128128
/omit-if-no-ref/
129-
fephym1_led_link: fephym1-led_link {
129+
fephym1_led_link: fephym1-led-link {
130130
rockchip,pins =
131131
/* fephy_led_link_m1 */
132132
<2 RK_PA6 5 &pcfg_pull_none>;
133133
};
134134

135135
/omit-if-no-ref/
136-
fephym1_led_spd: fephym1-led_spd {
136+
fephym1_led_spd: fephym1-led-spd {
137137
rockchip,pins =
138138
/* fephy_led_spd_m1 */
139139
<2 RK_PA5 5 &pcfg_pull_none>;
@@ -779,7 +779,7 @@
779779
};
780780

781781
/omit-if-no-ref/
782-
rgmii_rx_bus2: rgmii-rx_bus2 {
782+
rgmii_rx_bus2: rgmii-rx-bus2 {
783783
rockchip,pins =
784784
/* rgmii_rxd0 */
785785
<3 RK_PA3 2 &pcfg_pull_none>,
@@ -790,7 +790,7 @@
790790
};
791791

792792
/omit-if-no-ref/
793-
rgmii_tx_bus2: rgmii-tx_bus2 {
793+
rgmii_tx_bus2: rgmii-tx-bus2 {
794794
rockchip,pins =
795795
/* rgmii_txd0 */
796796
<3 RK_PA1 2 &pcfg_pull_none_drv_level_2>,
@@ -801,7 +801,7 @@
801801
};
802802

803803
/omit-if-no-ref/
804-
rgmii_rgmii_clk: rgmii-rgmii_clk {
804+
rgmii_rgmii_clk: rgmii-rgmii-clk {
805805
rockchip,pins =
806806
/* rgmii_rxclk */
807807
<3 RK_PA5 2 &pcfg_pull_none>,
@@ -810,7 +810,7 @@
810810
};
811811

812812
/omit-if-no-ref/
813-
rgmii_rgmii_bus: rgmii-rgmii_bus {
813+
rgmii_rgmii_bus: rgmii-rgmii-bus {
814814
rockchip,pins =
815815
/* rgmii_rxd2 */
816816
<3 RK_PA7 2 &pcfg_pull_none>,

0 commit comments

Comments
 (0)