Skip to content

Commit f45b294

Browse files
paulkocialkowskiwens
authored andcommitted
clk: sunxi-ng: v3s: Fix CSI SCLK clock name
The CSI SCLK clock is incorrectly called CSI1 SCLK while it is used for both the CSI0 and CSI1 interfaces and is called CSI SCLK all around the documentation. Fix the name in the driver, header and device-tree. Fixes: d0f11d1 ("clk: sunxi-ng: add support for V3s CCU") Signed-off-by: Paul Kocialkowski <[email protected]> Reviewed-By: Icenowy Zheng <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Chen-Yu Tsai <[email protected]>
1 parent 713d488 commit f45b294

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ examples:
110110
reg = <0x01cb4000 0x1000>;
111111
interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
112112
clocks = <&ccu CLK_BUS_CSI>,
113-
<&ccu CLK_CSI1_SCLK>,
113+
<&ccu CLK_CSI_SCLK>,
114114
<&ccu CLK_DRAM_CSI>;
115115
clock-names = "bus",
116116
"mod",

Documentation/devicetree/bindings/media/allwinner,sun6i-a31-isp.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ examples:
7979
reg = <0x01cb8000 0x1000>;
8080
interrupts = <GIC_SPI 83 IRQ_TYPE_LEVEL_HIGH>;
8181
clocks = <&ccu CLK_BUS_CSI>,
82-
<&ccu CLK_CSI1_SCLK>,
82+
<&ccu CLK_CSI_SCLK>,
8383
<&ccu CLK_DRAM_CSI>;
8484
clock-names = "bus", "mod", "ram";
8585
resets = <&ccu RST_BUS_CSI>;

Documentation/devicetree/bindings/media/allwinner,sun6i-a31-mipi-csi2.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ examples:
103103
reg = <0x01cb1000 0x1000>;
104104
interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
105105
clocks = <&ccu CLK_BUS_CSI>,
106-
<&ccu CLK_CSI1_SCLK>;
106+
<&ccu CLK_CSI_SCLK>;
107107
clock-names = "bus", "mod";
108108
resets = <&ccu RST_BUS_CSI>;
109109

arch/arm/boot/dts/allwinner/sun8i-v3s.dtsi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@
652652
reg = <0x01cb4000 0x3000>;
653653
interrupts = <GIC_SPI 84 IRQ_TYPE_LEVEL_HIGH>;
654654
clocks = <&ccu CLK_BUS_CSI>,
655-
<&ccu CLK_CSI1_SCLK>,
655+
<&ccu CLK_CSI_SCLK>,
656656
<&ccu CLK_DRAM_CSI>;
657657
clock-names = "bus", "mod", "ram";
658658
resets = <&ccu RST_BUS_CSI>;

drivers/clk/sunxi-ng/ccu-sun8i-v3s.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -362,8 +362,8 @@ static const char * const csi_mclk_parents[] = { "osc24M", "pll-video",
362362
static SUNXI_CCU_M_WITH_MUX_GATE(csi0_mclk_clk, "csi0-mclk", csi_mclk_parents,
363363
0x130, 0, 5, 8, 3, BIT(15), 0);
364364

365-
static const char * const csi1_sclk_parents[] = { "pll-video", "pll-isp" };
366-
static SUNXI_CCU_M_WITH_MUX_GATE(csi1_sclk_clk, "csi-sclk", csi1_sclk_parents,
365+
static const char * const csi_sclk_parents[] = { "pll-video", "pll-isp" };
366+
static SUNXI_CCU_M_WITH_MUX_GATE(csi_sclk_clk, "csi-sclk", csi_sclk_parents,
367367
0x134, 16, 4, 24, 3, BIT(31), 0);
368368

369369
static SUNXI_CCU_M_WITH_MUX_GATE(csi1_mclk_clk, "csi-mclk", csi_mclk_parents,
@@ -452,7 +452,7 @@ static struct ccu_common *sun8i_v3s_ccu_clks[] = {
452452
&tcon_clk.common,
453453
&csi_misc_clk.common,
454454
&csi0_mclk_clk.common,
455-
&csi1_sclk_clk.common,
455+
&csi_sclk_clk.common,
456456
&csi1_mclk_clk.common,
457457
&ve_clk.common,
458458
&ac_dig_clk.common,
@@ -551,7 +551,7 @@ static struct clk_hw_onecell_data sun8i_v3s_hw_clks = {
551551
[CLK_TCON0] = &tcon_clk.common.hw,
552552
[CLK_CSI_MISC] = &csi_misc_clk.common.hw,
553553
[CLK_CSI0_MCLK] = &csi0_mclk_clk.common.hw,
554-
[CLK_CSI1_SCLK] = &csi1_sclk_clk.common.hw,
554+
[CLK_CSI_SCLK] = &csi_sclk_clk.common.hw,
555555
[CLK_CSI1_MCLK] = &csi1_mclk_clk.common.hw,
556556
[CLK_VE] = &ve_clk.common.hw,
557557
[CLK_AC_DIG] = &ac_dig_clk.common.hw,
@@ -633,7 +633,7 @@ static struct clk_hw_onecell_data sun8i_v3_hw_clks = {
633633
[CLK_TCON0] = &tcon_clk.common.hw,
634634
[CLK_CSI_MISC] = &csi_misc_clk.common.hw,
635635
[CLK_CSI0_MCLK] = &csi0_mclk_clk.common.hw,
636-
[CLK_CSI1_SCLK] = &csi1_sclk_clk.common.hw,
636+
[CLK_CSI_SCLK] = &csi_sclk_clk.common.hw,
637637
[CLK_CSI1_MCLK] = &csi1_mclk_clk.common.hw,
638638
[CLK_VE] = &ve_clk.common.hw,
639639
[CLK_AC_DIG] = &ac_dig_clk.common.hw,

include/dt-bindings/clock/sun8i-v3s-ccu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
#define CLK_TCON0 64
9797
#define CLK_CSI_MISC 65
9898
#define CLK_CSI0_MCLK 66
99-
#define CLK_CSI1_SCLK 67
99+
#define CLK_CSI_SCLK 67
100100
#define CLK_CSI1_MCLK 68
101101
#define CLK_VE 69
102102
#define CLK_AC_DIG 70

0 commit comments

Comments
 (0)