Skip to content

Commit f5443d0

Browse files
committed
erofs: use memcpy_to_folio() to replace copy_to_iter()
Using copy_to_iter() here is overkill and even messy. Signed-off-by: Gao Xiang <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent 99f7619 commit f5443d0

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

fs/erofs/fileio.c

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ static int erofs_fileio_scan_folio(struct erofs_fileio *io, struct folio *folio)
9696
struct erofs_map_blocks *map = &io->map;
9797
unsigned int cur = 0, end = folio_size(folio), len, attached = 0;
9898
loff_t pos = folio_pos(folio), ofs;
99-
struct iov_iter iter;
100-
struct bio_vec bv;
10199
int err = 0;
102100

103101
erofs_onlinefolio_init(folio);
@@ -122,13 +120,7 @@ static int erofs_fileio_scan_folio(struct erofs_fileio *io, struct folio *folio)
122120
err = PTR_ERR(src);
123121
break;
124122
}
125-
bvec_set_folio(&bv, folio, len, cur);
126-
iov_iter_bvec(&iter, ITER_DEST, &bv, 1, len);
127-
if (copy_to_iter(src, len, &iter) != len) {
128-
erofs_put_metabuf(&buf);
129-
err = -EIO;
130-
break;
131-
}
123+
memcpy_to_folio(folio, cur, src, len);
132124
erofs_put_metabuf(&buf);
133125
} else if (!(map->m_flags & EROFS_MAP_MAPPED)) {
134126
folio_zero_segment(folio, cur, cur + len);

0 commit comments

Comments
 (0)