Skip to content

Commit fe24d5b

Browse files
brettcreeleyawilliam
authored andcommitted
vfio/pds: Fix missing detach_ioas op
When CONFIG_IOMMUFD is enabled and a device is bound to the pds_vfio_pci driver, the following WARN_ON() trace is seen and probe fails: WARNING: CPU: 0 PID: 5040 at drivers/vfio/vfio_main.c:317 __vfio_register_dev+0x130/0x140 [vfio] <...> pds_vfio_pci 0000:08:00.1: probe with driver pds_vfio_pci failed with error -22 This is because the driver's vfio_device_ops.detach_ioas isn't set. Fix this by using the generic vfio_iommufd_physical_detach_ioas function. Fixes: 38fe397 ("vfio/pds: Initial support for pds VFIO driver") Signed-off-by: Brett Creeley <[email protected]> Reviewed-by: Kevin Tian <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alex Williamson <[email protected]>
1 parent 982ddd5 commit fe24d5b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/vfio/pci/pds/vfio_dev.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ static const struct vfio_device_ops pds_vfio_ops = {
204204
.bind_iommufd = vfio_iommufd_physical_bind,
205205
.unbind_iommufd = vfio_iommufd_physical_unbind,
206206
.attach_ioas = vfio_iommufd_physical_attach_ioas,
207+
.detach_ioas = vfio_iommufd_physical_detach_ioas,
207208
};
208209

209210
const struct vfio_device_ops *pds_vfio_ops_info(void)

0 commit comments

Comments
 (0)