Skip to content

Commit ff53a6e

Browse files
djbwrafaeljw
authored andcommitted
driver core: faux: Quiet probe failures
The acpi-einj conversion to faux_device_create() leads to a noisy error message when the error injection facility is disabled. Quiet the error as CXL error injection via ACPI expects the module to stay loaded even if the error injection facility is disabled. This situation arose because CXL knows proper kernel named objects to trigger errors against, but acpi-einj knows how to perform the error injection. The injection mechanism is shared with non-CXL use cases. The result is CXL now has a module dependency on einj-core.ko, and init/probe failures are handled at runtime. Fixes: 6cb9441 ("ACPI: APEI: EINJ: Transition to the faux device interface") Signed-off-by: Dan Williams <[email protected]> Reviewed-by: Jonathan Cameron <[email protected]> Acked-by: Greg Kroah-Hartman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Rafael J. Wysocki <[email protected]>
1 parent c393bef commit ff53a6e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/base/faux.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ struct faux_device *faux_device_create_with_groups(const char *name,
170170
* successful is almost impossible to determine by the caller.
171171
*/
172172
if (!dev->driver) {
173-
dev_err(dev, "probe did not succeed, tearing down the device\n");
173+
dev_dbg(dev, "probe did not succeed, tearing down the device\n");
174174
faux_device_destroy(faux_dev);
175175
faux_dev = NULL;
176176
}

0 commit comments

Comments
 (0)