Skip to content

bpf, arm64: support for timed may_goto #9439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

bpf, arm64: support for timed may_goto #9439

wants to merge 2 commits into from

Conversation

kernel-patches-daemon-bpf[bot]
Copy link

Pull request for series with
subject: bpf, arm64: support for timed may_goto
version: 2
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: fa47913
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 9e293d4
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 3e2b799
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: c93c59b
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: bf0c2a8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 2caa6b8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 0786654
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: dc0fe95
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: c80d797
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: b5bbbb7
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 2693227
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 78e097f
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 21aeabb
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 0780f54
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: d47cc4d
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@kernel-patches-daemon-bpf
Copy link
Author

Upstream branch: 4223bf8
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=989634
version: 2

@puranjaymohan
bpf, arm64: Add JIT support for timed may_goto
2659a4c 
When verifier sees a timed may_goto instruction, it emits a call to
arch_bpf_timed_may_goto() with a stack offset in BPF_REG_AX (arm64 r9)
and expects a count value to be returned in the same register. The
verifier doesn't save or restore any registers before emitting this
call.

arch_bpf_timed_may_goto() should act as a trampoline to call
bpf_check_timed_may_goto() with AAPCS64 calling convention.

To support this custom calling convention, implement
arch_bpf_timed_may_goto() in assembly and make sure BPF caller saved
registers are saved and restored, call bpf_check_timed_may_goto with
arm64 calling convention where first argument and return value both are
in x0, then put the result back into BPF_REG_AX before returning.

Signed-off-by: Puranjay Mohan <[email protected]>
@puranjaymohan
selftests/bpf: Enable timed may_goto tests for arm64
4a125e7 
As arm64 JIT now supports timed may_goto instruction, make sure all
relevant tests run on this architecture. Some tests were enabled and
other required modifications to work properly on arm64.

 $ ./test_progs -a "stream*","*may_goto*",verifier_bpf_fastcall

 #404     stream_errors:OK
 [...]
 #406/2   stream_success/stream_cond_break:OK
 [...]
 #494/23  verifier_bpf_fastcall/may_goto_interaction_x86_64:SKIP
 #494/24  verifier_bpf_fastcall/may_goto_interaction_arm64:OK
 [...]
 #539/1   verifier_may_goto_1/may_goto 0:OK
 #539/2   verifier_may_goto_1/batch 2 of may_goto 0:OK
 #539/3   verifier_may_goto_1/may_goto batch with offsets 2/1/0:OK
 #539/4   verifier_may_goto_1/may_goto batch with offsets 2/0:OK
 #539     verifier_may_goto_1:OK
 #540/1   verifier_may_goto_2/C code with may_goto 0:OK
 #540     verifier_may_goto_2:OK
 Summary: 7/16 PASSED, 25 SKIPPED, 0 FAILED

Signed-off-by: Puranjay Mohan <[email protected]>
@kernel-patches-daemon-bpf kernel-patches-daemon-bpf bot deleted the series/989634=>bpf-next branch August 26, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bpf-next new V2-ci-pass V2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@puranjaymohan