fprobe: use rhashtable for fprobe_ip_table #9504
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kernel-patches-daemon-bpf[bot]](https://avatars.githubusercontent.com/u/70728002?s=60&v=4){kind=small}
|
Upstream branch: 3ec8560 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
715d6cb to
506c27a
Compare
|
Upstream branch: 1274163 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/992227=>bpf-next
branch
from
bc3480c to
81bcc3e
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
506c27a to
76c716d
Compare
|
Upstream branch: d87fdb1 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/992227=>bpf-next
branch
from
81bcc3e to
f38bd46
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
76c716d to
f3b4b37
Compare
|
Upstream branch: dbe99ea |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/992227=>bpf-next
branch
from
f38bd46 to
362a37f
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
f3b4b37 to
bf66d41
Compare
|
Upstream branch: 6850a33 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/992227=>bpf-next
branch
from
362a37f to
021a471
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
bf66d41 to
74b5324
Compare
|
Upstream branch: dbe99ea |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/992227=>bpf-next
branch
from
021a471 to
08c84cb
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
74b5324 to
c3c6b4b
Compare
|
Upstream branch: 5c42715 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/992227=>bpf-next
branch
from
08c84cb to
66dccc3
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c3c6b4b to
1a79214
Compare
|
Upstream branch: bf7a6a6 |
For now, all the kernel functions who are hooked by the fprobe will be added to the hash table "fprobe_ip_table". The key of it is the function address, and the value of it is "struct fprobe_hlist_node". The budget of the hash table is FPROBE_IP_TABLE_SIZE, which is 256. And this means the overhead of the hash table lookup will grow linearly if the count of the functions in the fprobe more than 256. When we try to hook all the kernel functions, the overhead will be huge. Therefore, replace the hash table with rhltable to reduce the overhead. Signed-off-by: Menglong Dong <[email protected]>
We need to get all the kernel function that can be traced sometimes, so we move the get_syms() and get_addrs() in kprobe_multi_test.c to trace_helpers.c and rename it to bpf_get_ksyms() and bpf_get_addrs(). Signed-off-by: Menglong Dong <[email protected]>
Some functions is recursive for the kprobe_multi and impact the benchmark results. So just skip them. Signed-off-by: Menglong Dong <[email protected]>
For now, the benchmark for kprobe-multi is single, which means there is only 1 function is hooked during testing. Add the testing "kprobe-multi-all", which will hook all the kernel functions during the benchmark. And the "kretprobe-multi-all" is added too. Signed-off-by: Menglong Dong <[email protected]>
kernel-patches-daemon-bpf
bot
force-pushed
the
series/992227=>bpf-next
branch
from
66dccc3 to
a4d95dc
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=992227 expired. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: fprobe: use rhashtable for fprobe_ip_table
version: 5
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=992227