review: add installation step && update error message

Author: archandatta

cmd/create.go

@@ -46,12 +46,24 @@ func (c CreateCmd) Create(ctx context.Context, ci CreateInput) error {
 		return fmt.Errorf("failed to copy template files: %w", err)
 	}
 
-	if err := create.InstallDependencies(appPath, ci.Language); err != nil {
-		spinner.Fail("Failed to install dependencies")
-		return fmt.Errorf("failed to install dependencies: %w", err)
+	ok, _ := create.InstallDependencies(appPath, ci.Language)
+	if !ok {
+		pterm.Warning.Println("Failed to install dependencies. Please install them manually:")
+		switch ci.Language {
+		case create.LanguageTypeScript:
+			pterm.Println(fmt.Sprintf("  cd %s", ci.Name))
+			pterm.Println("  npm install")
+		case create.LanguagePython:
+			pterm.Println(fmt.Sprintf("  cd %s", ci.Name))
+			pterm.Println("  uv venv && source .venv/bin/activate && uv sync")
+		}
+		pterm.Println()
+	} else {
+		spinner.Success(fmt.Sprintf("✔ %s environment set up successfully", ci.Language))
 	}
 
-	spinner.Success(fmt.Sprintf("✔ %s environment set up successfully", ci.Language))
+	pterm.Success.Println("🎉 Kernel app created successfully!")
+	pterm.Println()
 
 	nextSteps := fmt.Sprintf(`Next steps:
   brew install onkernel/tap/kernel
@@ -61,8 +73,6 @@ func (c CreateCmd) Create(ctx context.Context, ci CreateInput) error {
   kernel invoke ts-basic get-page-title --payload '{"url": "https://www.google.com"}'
 `, ci.Name)
 
-	pterm.Success.Println("🎉 Kernel app created successfully!")
-	pterm.Println()
 	pterm.FgYellow.Println(nextSteps)
 
 	return nil

cmd/create_test.go

@@ -218,6 +218,42 @@ func validatePythonTemplate(t *testing.T, appPath string, checkDependencies bool
 	}
 }
 
+// TestCreateCommand_DependencyInstallationFails tests that the app is still created
+// even when dependency installation fails, with appropriate warning message
+func TestCreateCommand_DependencyInstallationFails(t *testing.T) {
+	tmpDir := t.TempDir()
+	appName := "test-app"
+
+	orgDir, err := os.Getwd()
+	require.NoError(t, err)
+
+	err = os.Chdir(tmpDir)
+	require.NoError(t, err)
+
+	t.Cleanup(func() {
+		os.Chdir(orgDir)
+	})
+
+	// Override the install command to use a command that will fail
+	originalInstallCommands := create.InstallCommands
+	create.InstallCommands = map[string]string{
+		create.LanguageTypeScript: "exit 1", // Command that always fails
+	}
+
+	// Restore original install commands after test
+	t.Cleanup(func() {
+		create.InstallCommands = originalInstallCommands
+	})
+
+	// Create the app - should succeed even though dependency installation fails
+	c := CreateCmd{}
+	err = c.Create(context.Background(), CreateInput{
+		Name:     appName,
+		Language: create.LanguageTypeScript,
+		Template: "sample-app",
+	})
+}
+
 func getTemplateInfo() []struct {
 	name     string
 	language string

pkg/create/dependencies.go

@@ -3,16 +3,15 @@ package create
 import (
 	"fmt"
 	"os/exec"
-	"path/filepath"
 
 	"github.com/pterm/pterm"
 )
 
 // InstallDependencies sets up project dependencies based on language
-func InstallDependencies(appPath string, language string) error {
+func InstallDependencies(appPath string, language string) (bool, error) {
 	installCommand, ok := InstallCommands[language]
 	if !ok {
-		return fmt.Errorf("unsupported language: %s", language)
+		return false, fmt.Errorf("unsupported language: %s", language)
 	}
 
 	spinner, _ := pterm.DefaultSpinner.Start(fmt.Sprintf("Setting up %s environment...", language))
@@ -21,22 +20,10 @@ func InstallDependencies(appPath string, language string) error {
 	cmd.Dir = appPath
 
 	if err := cmd.Run(); err != nil {
-		spinner.Fail(fmt.Sprintf("Failed to set up %s environment", language))
-		pterm.Error.Printf("Error: %v\n", err)
-
-		pterm.FgYellow.Println("\nPlease install dependencies manually:")
-		switch language {
-		case LanguageTypeScript:
-			pterm.Println(fmt.Sprintf("  cd %s", filepath.Base(appPath)))
-			pterm.Println("  npm install")
-		case LanguagePython:
-			pterm.Println(fmt.Sprintf("  cd %s", filepath.Base(appPath)))
-			pterm.Println("  uv venv && source .venv/bin/activate && uv sync")
-		}
-
-		return nil
+		spinner.Stop()
+		return false, nil
 	}
 
 	spinner.Success(fmt.Sprintf("%s environment set up successfully", language))
-	return nil
+	return true, nil
 }

pkg/create/types.go

@@ -16,7 +16,7 @@ const (
 
 var InstallCommands = map[string]string{
 	LanguageTypeScript: "npm install",
-	LanguagePython:     "uv venv",
+	LanguagePython:     "uv venv && source .venv/bin/activate && uv sync",
 }
 
 // SupportedLanguages returns a list of all supported languages