review: add app name validation with flag

Author: archandatta

cmd/create.go

@@ -68,7 +68,7 @@ func runCreateApp(cmd *cobra.Command, args []string) error {
 		spinner.Fail("Failed to copy template files")
 		return fmt.Errorf("failed to copy template files: %w", err)
 	}
-	spinner.Success("✔ TypeScript environment set up successfully")
+	spinner.Success(fmt.Sprintf("✔ %s environment set up successfully", language))
 
 	nextSteps := fmt.Sprintf(`Next steps:
   brew install onkernel/tap/kernel

cmd/root.go

@@ -129,8 +129,7 @@ func init() {
 	rootCmd.AddCommand(profilesCmd)
 	rootCmd.AddCommand(proxies.ProxiesCmd)
 	rootCmd.AddCommand(extensionsCmd)
-	// Hide create command while WIP
-	// rootCmd.AddCommand(createCmd)
+	rootCmd.AddCommand(createCmd)
 
 	rootCmd.PersistentPostRunE = func(cmd *cobra.Command, args []string) error {
 		// running synchronously so we never slow the command

pkg/create/prompts.go

@@ -8,6 +8,8 @@ import (
 	"github.com/pterm/pterm"
 )
 
+// validateAppName validates that an app name follows the required format.
+// Returns an error if the name is invalid.
 func validateAppName(val any) error {
 	str, ok := val.(string)
 	if !ok {
@@ -29,11 +31,8 @@ func validateAppName(val any) error {
 	return nil
 }
 
-func PromptForAppName(providedAppName string) (string, error) {
-	if providedAppName != "" {
-		return providedAppName, nil
-	}
-
+// handleAppNamePrompt prompts the user for an app name interactively.
+func handleAppNamePrompt() (string, error) {
 	promptText := fmt.Sprintf("%s (default: %s)", AppNamePrompt, DefaultAppName)
 	appName, err := pterm.DefaultInteractiveTextInput.
 		WithDefaultText(promptText).
@@ -42,19 +41,36 @@ func PromptForAppName(providedAppName string) (string, error) {
 		return "", err
 	}
 
-	// Use default if user just pressed enter without typing anything
 	if appName == "" {
 		appName = DefaultAppName
 	}
 
-	// Validate the app name
 	if err := validateAppName(appName); err != nil {
-		return "", err
+		pterm.Warning.Printf("Invalid app name '%s': %v\n", appName, err)
+		pterm.Info.Println("Please provide a valid app name.")
+		return handleAppNamePrompt()
 	}
 
 	return appName, nil
 }
 
+// PromptForAppName validates the provided app name or prompts the user for one.
+// If the provided name is invalid, it shows a warning and prompts the user.
+func PromptForAppName(providedAppName string) (string, error) {
+	// If no app name was provided, prompt the user
+	if providedAppName == "" {
+		return handleAppNamePrompt()
+	}
+
+	if err := validateAppName(providedAppName); err != nil {
+		pterm.Warning.Printf("Invalid app name '%s': %v\n", providedAppName, err)
+		pterm.Info.Println("Please provide a valid app name.")
+		return handleAppNamePrompt()
+	}
+
+	return providedAppName, nil
+}
+
 func handleLanguagePrompt() (string, error) {
 	l, err := pterm.DefaultInteractiveSelect.
 		WithOptions(SupportedLanguages).