refactor: use koanf env provider for HYPEMAN_ env vars

Load HYPEMAN_BASE_URL and HYPEMAN_API_KEY via koanf's env provider
in loadCLIConfig() instead of manual os.Getenv checks. This gives
consistent precedence (env > config file) in one place.

HYPEMAN_BEARER_TOKEN remains as a legacy fallback checked separately.

Author: rgarcia

go.mod

@@ -52,6 +52,7 @@ require (
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.27.2 // indirect
 	github.com/klauspost/compress v1.18.1 // indirect
 	github.com/knadh/koanf/maps v0.1.2 // indirect
+	github.com/knadh/koanf/providers/env v1.1.0 // indirect
 	github.com/lucasb-eyer/go-colorful v1.2.0 // indirect
 	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/mattn/go-localereader v0.0.1 // indirect

go.sum

@@ -84,6 +84,8 @@ github.com/knadh/koanf/maps v0.1.2 h1:RBfmAW5CnZT+PJ1CVc1QSJKf4Xu9kxfQgYVQSu8hpb
 github.com/knadh/koanf/maps v0.1.2/go.mod h1:npD/QZY3V6ghQDdcQzl1W4ICNVTkohC8E73eI2xW4yI=
 github.com/knadh/koanf/parsers/yaml v1.1.0 h1:3ltfm9ljprAHt4jxgeYLlFPmUaunuCgu1yILuTXRdM4=
 github.com/knadh/koanf/parsers/yaml v1.1.0/go.mod h1:HHmcHXUrp9cOPcuC+2wrr44GTUB0EC+PyfN3HZD9tFg=
+github.com/knadh/koanf/providers/env v1.1.0 h1:U2VXPY0f+CsNDkvdsG8GcsnK4ah85WwWyJgef9oQMSc=
+github.com/knadh/koanf/providers/env v1.1.0/go.mod h1:QhHHHZ87h9JxJAn2czdEl6pdkNnDh/JS1Vtsyt65hTY=
 github.com/knadh/koanf/providers/file v1.2.1 h1:bEWbtQwYrA+W2DtdBrQWyXqJaJSG3KrP3AESOJYp9wM=
 github.com/knadh/koanf/providers/file v1.2.1/go.mod h1:bp1PM5f83Q+TOUu10J/0ApLBd9uIzg+n9UgthfY+nRA=
 github.com/knadh/koanf/v2 v2.3.2 h1:Ee6tuzQYFwcZXQpc2MiVeC6qHMandf5SMUJJNoFp/c4=

pkg/cmd/config.go

@@ -3,8 +3,10 @@ package cmd
 import (
 	"os"
 	"path/filepath"
+	"strings"
 
 	"github.com/knadh/koanf/parsers/yaml"
+	"github.com/knadh/koanf/providers/env"
 	"github.com/knadh/koanf/providers/file"
 	"github.com/knadh/koanf/v2"
 	"github.com/urfave/cli/v3"
@@ -26,35 +28,37 @@ func getCLIConfigPath() string {
 	return filepath.Join(home, ".config", "hypeman", "cli.yaml")
 }
 
-// loadCLIConfig loads CLI configuration from the config file.
+// loadCLIConfig loads CLI configuration from the config file, then
+// overlays HYPEMAN_-prefixed environment variables (highest precedence).
+// HYPEMAN_BASE_URL -> base_url, HYPEMAN_API_KEY -> api_key.
 // Returns an empty config if the file doesn't exist or can't be parsed.
 func loadCLIConfig() *CLIConfig {
 	cfg := &CLIConfig{}
+	k := koanf.New(".")
 
 	configPath := getCLIConfigPath()
-	if configPath == "" {
-		return cfg
+	if configPath != "" {
+		_ = k.Load(file.Provider(configPath), yaml.Parser())
 	}
 
-	k := koanf.New(".")
-	if err := k.Load(file.Provider(configPath), yaml.Parser()); err != nil {
-		// File doesn't exist or can't be parsed - return empty config
-		return cfg
-	}
+	// Overlay HYPEMAN_-prefixed env vars: HYPEMAN_BASE_URL -> base_url
+	_ = k.Load(env.ProviderWithValue("HYPEMAN_", ".", func(key string, value string) (string, interface{}) {
+		if value == "" {
+			return "", nil
+		}
+		return strings.ToLower(strings.TrimPrefix(key, "HYPEMAN_")), value
+	}), nil)
 
 	_ = k.Unmarshal("", cfg)
 	return cfg
 }
 
 // resolveBaseURL returns the effective base URL with precedence:
-// CLI flag > env var > config file > default.
+// CLI flag > HYPEMAN_BASE_URL env > config file > default.
 func resolveBaseURL(cmd *cli.Command) string {
 	if u := cmd.Root().String("base-url"); u != "" {
 		return u
 	}
-	if u := os.Getenv("HYPEMAN_BASE_URL"); u != "" {
-		return u
-	}
 	cfg := loadCLIConfig()
 	if cfg.BaseURL != "" {
 		return cfg.BaseURL
@@ -63,14 +67,14 @@ func resolveBaseURL(cmd *cli.Command) string {
 }
 
 // resolveAPIKey returns the effective API key with precedence:
-// HYPEMAN_API_KEY env var > HYPEMAN_BEARER_TOKEN env var (legacy) > config file.
+// HYPEMAN_API_KEY env > config file > HYPEMAN_BEARER_TOKEN env (legacy).
 func resolveAPIKey() string {
-	if k := os.Getenv("HYPEMAN_API_KEY"); k != "" {
-		return k
+	cfg := loadCLIConfig()
+	if cfg.APIKey != "" {
+		return cfg.APIKey
 	}
 	if k := os.Getenv("HYPEMAN_BEARER_TOKEN"); k != "" {
 		return k
 	}
-	cfg := loadCLIConfig()
-	return cfg.APIKey
+	return ""
 }