Skip to content

Commit 2169a4d

Browse files
committed
Fix test
1 parent 433b946 commit 2169a4d

File tree

1 file changed

+11
-14
lines changed

1 file changed

+11
-14
lines changed

lib/vmm/client_test.go

Lines changed: 11 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -161,15 +161,15 @@ func TestStartProcessCreatesLogFiles(t *testing.T) {
161161
require.NoError(t, err)
162162
assert.Greater(t, pid, 0)
163163

164-
// Verify log files exist - they are created and accessible by the daemon
165-
stdoutLog := filepath.Join(tmpDir, "ch-stdout.log")
166-
stderrLog := filepath.Join(tmpDir, "ch-stderr.log")
164+
// Verify logs directory and vmm.log file exist
165+
logsDir := filepath.Join(tmpDir, "logs")
166+
vmmLog := filepath.Join(logsDir, "vmm.log")
167167

168-
_, err = os.Stat(stdoutLog)
169-
require.NoError(t, err, "stdout log should exist")
168+
_, err = os.Stat(logsDir)
169+
require.NoError(t, err, "logs directory should exist")
170170

171-
_, err = os.Stat(stderrLog)
172-
require.NoError(t, err, "stderr log should exist")
171+
_, err = os.Stat(vmmLog)
172+
require.NoError(t, err, "vmm.log should exist")
173173

174174
// Verify the daemon is running and responsive
175175
client, err := NewVMM(socketPath)
@@ -179,16 +179,13 @@ func TestStartProcessCreatesLogFiles(t *testing.T) {
179179
require.NoError(t, err)
180180
assert.Equal(t, 200, pingResp.StatusCode())
181181

182-
// Read log files - with verbose mode, Cloud Hypervisor writes to logs
183-
stdoutContent, err := os.ReadFile(stdoutLog)
184-
require.NoError(t, err)
185-
stderrContent, err := os.ReadFile(stderrLog)
182+
// Read log file - with verbose mode, Cloud Hypervisor writes to logs
183+
vmmContent, err := os.ReadFile(vmmLog)
186184
require.NoError(t, err)
187185

188186
// Verify that logs contain output (proves daemon can write after parent closed files)
189-
totalLogSize := len(stdoutContent) + len(stderrContent)
190-
assert.Greater(t, totalLogSize, 0,
191-
"Cloud Hypervisor daemon should write logs even after parent closed the file descriptors")
187+
assert.Greater(t, len(vmmContent), 0,
188+
"Cloud Hypervisor daemon should write logs even after parent closed the file descriptor")
192189

193190
// Cleanup
194191
client.ShutdownVMMWithResponse(ctx)

0 commit comments

Comments
 (0)