Give ingress 5s to be ready

Author: sjmiller609

lib/instances/manager_test.go

@@ -401,11 +401,13 @@ func TestBasicEndToEnd(t *testing.T) {
 
 	// Make HTTP request through Envoy to nginx with retry
 	// Envoy watches the xDS files and reloads automatically, but we retry to handle timing
+	// Envoy may take a few seconds to detect file changes and start the new listener
 	t.Log("Making HTTP request through Envoy to nginx...")
 	client := &http.Client{Timeout: 2 * time.Second}
 	var resp *http.Response
 	var lastErr error
-	for attempt := 0; attempt < 10; attempt++ {
+	deadline := time.Now().Add(5 * time.Second)
+	for time.Now().Before(deadline) {
 		req, err := http.NewRequest("GET", fmt.Sprintf("http://127.0.0.1:%d/", ingressPort), nil)
 		require.NoError(t, err)
 		req.Host = "test.local" // Set Host header to match ingress rule
@@ -419,7 +421,7 @@ func TestBasicEndToEnd(t *testing.T) {
 		}
 		time.Sleep(100 * time.Millisecond)
 	}
-	require.NoError(t, lastErr, "HTTP request through Envoy should succeed")
+	require.NoError(t, lastErr, "HTTP request through Envoy should succeed within 5 seconds")
 	require.NotNil(t, resp)
 	defer resp.Body.Close()